Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust toolchain #1335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add rust toolchain #1335

wants to merge 1 commit into from

Conversation

Shourya742
Copy link
Contributor

closes: #1333

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🐰 Bencher Report

Branch2025-add-rust-toolchain
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2.11
(+0.10%)		2.23
(94.66%)		📈 view plot
🚷 view threshold		470.00
(-0.75%)		490.74
(95.77%)		📈 view plot
🚷 view threshold		734.00
(-0.27%)		759.43
(96.65%)		📈 view plot
🚷 view threshold		3.00
(-40.37%)		11.79
(25.44%)		📈 view plot
🚷 view threshold		39.00
(+1.05%)		41.63
(93.67%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8.27
(+0.53%)		8.40
(98.47%)		📈 view plot
🚷 view threshold		2,137.00📈 view plot
🚷 view threshold		3,158.00
(-0.02%)		3,167.53
(99.70%)		📈 view plot
🚷 view threshold		35.00
(-1.65%)		41.77
(83.80%)		📈 view plot
🚷 view threshold		141.00
(+0.96%)		144.46
(97.60%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6.27
(-0.54%)		6.45
(97.20%)		📈 view plot
🚷 view threshold		1,747.00
(-0.20%)		1,767.74
(98.83%)		📈 view plot
🚷 view threshold		2,551.00
(-0.03%)		2,575.99
(99.03%)		📈 view plot
🚷 view threshold		15.00
(-12.73%)		24.54
(61.12%)		📈 view plot
🚷 view threshold		104.00
(-0.60%)		108.71
(95.67%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14.73
(+0.06%)		14.93
(98.67%)		📈 view plot
🚷 view threshold		4,691.00
(-0.08%)		4,711.74
(99.56%)		📈 view plot
🚷 view threshold		6,748.00
(-0.12%)		6,786.79
(99.43%)		📈 view plot
🚷 view threshold		50.00
(+10.00%)		62.34
(80.21%)		📈 view plot
🚷 view threshold		221.00
(-0.07%)		226.11
(97.74%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27.77
(+0.61%)		28.05
(99.00%)		📈 view plot
🚷 view threshold		10,642.00
(+0.34%)		10,695.81
(99.50%)		📈 view plot
🚷 view threshold		15,505.00
(+0.43%)		15,589.49
(99.46%)		📈 view plot
🚷 view threshold		86.00
(+2.87%)		98.71
(87.12%)		📈 view plot
🚷 view threshold		338.00
(+0.76%)		342.99
(98.54%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4.40
(+0.07%)		4.57
(96.29%)		📈 view plot
🚷 view threshold		1,458.00
(-0.24%)		1,478.74
(98.60%)		📈 view plot
🚷 view threshold		2,157.00
(-0.17%)		2,184.95
(98.72%)		📈 view plot
🚷 view threshold		8.00
(-1.82%)		13.87
(57.70%)		📈 view plot
🚷 view threshold		63.00
(+0.34%)		67.47
(93.38%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		13.98
(-0.25%)		14.20
(98.50%)		📈 view plot
🚷 view threshold		5,061.00
(-0.07%)		5,081.74
(99.59%)		📈 view plot
🚷 view threshold		7,323.00
(-0.04%)		7,352.88
(99.59%)		📈 view plot
🚷 view threshold		37.00
(+1.54%)		47.88
(77.27%)		📈 view plot
🚷 view threshold		185.00
(-0.53%)		190.78
(96.97%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22.87
(+0.74%)		23.05
(99.24%)		📈 view plot
🚷 view threshold		8,037.00
(+0.06%)		8,057.09
(99.75%)		📈 view plot
🚷 view threshold		11,689.00
(+0.04%)		11,713.96
(99.79%)		📈 view plot
🚷 view threshold		80.00
(+5.74%)		89.45
(89.44%)		📈 view plot
🚷 view threshold		308.00
(+1.34%)		312.16
(98.67%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4.66
(-0.58%)		4.79
(97.35%)		📈 view plot
🚷 view threshold		1,499.00
(-0.24%)		1,519.74
(98.64%)		📈 view plot
🚷 view threshold		2,277.00
(-0.07%)		2,301.29
(98.94%)		📈 view plot
🚷 view threshold		8.00
(-15.02%)		15.35
(52.11%)		📈 view plot
🚷 view threshold		67.00
(-0.79%)		70.06
(95.64%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16.17
(+0.10%)		16.32
(99.08%)		📈 view plot
🚷 view threshold		5,960.00
(-0.06%)		5,980.74
(99.65%)		📈 view plot
🚷 view threshold		8,654.00
(-0.12%)		8,692.69
(99.55%)		📈 view plot
🚷 view threshold		47.00
(+16.32%)		55.44
(84.77%)		📈 view plot
🚷 view threshold		208.00
(-0.09%)		212.02
(98.10%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35.76
(+0.45%)		35.94
(99.49%)		📈 view plot
🚷 view threshold		14,885.00
(+0.12%)		14,917.82
(99.78%)		📈 view plot
🚷 view threshold		21,869.00
(+0.12%)		21,917.31
(99.78%)		📈 view plot
🚷 view threshold		104.00
(+10.55%)		118.59
(87.70%)		📈 view plot
🚷 view threshold		382.00
(+0.64%)		385.63
(99.06%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🐰 Bencher Report

Branch2025-add-rust-toolchain
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
1e3 x instructions
(Result Δ%)		Upper Boundary
1e3 x instructions
(Limit %)		L1 AccessesBenchmark Result
1e3 x accesses
(Result Δ%)		Upper Boundary
1e3 x accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8.41
(-0.47%)		8.67
(97.04%)		📈 view plot
🚷 view threshold		3.66
(-1.69%)		3.86
(94.87%)		📈 view plot
🚷 view threshold		5.11
(-2.05%)		5.45
(93.82%)		📈 view plot
🚷 view threshold		10.00
(+19.29%)		16.07
(62.21%)		📈 view plot
🚷 view threshold		93.00
(+1.87%)		96.61
(96.26%)
get_submit📈 view plot
🚷 view threshold		95.35
(-0.01%)		95.61
(99.72%)		📈 view plot
🚷 view threshold		59.26
(-0.24%)		59.71
(99.26%)		📈 view plot
🚷 view threshold		85.08
(-0.28%)		85.82
(99.14%)		📈 view plot
🚷 view threshold		45.00
(+1.05%)		59.95
(75.06%)		📈 view plot
🚷 view threshold		287.00
(+2.28%)		291.43
(98.48%)
get_subscribe📈 view plot
🚷 view threshold		7.92
(-1.01%)		8.23
(96.17%)		📈 view plot
🚷 view threshold		2.76
(-1.98%)		2.94
(93.72%)		📈 view plot
🚷 view threshold		3.83
(-2.31%)		4.14
(92.57%)		📈 view plot
🚷 view threshold		11.00
(-11.50%)		20.57
(53.48%)		📈 view plot
🚷 view threshold		115.00
(+0.42%)		117.87
(97.57%)
serialize_authorize📈 view plot
🚷 view threshold		12.20
(-0.51%)		12.50
(97.54%)		📈 view plot
🚷 view threshold		5.24
(-1.12%)		5.43
(96.58%)		📈 view plot
🚷 view threshold		7.28
(-1.37%)		7.60
(95.78%)		📈 view plot
🚷 view threshold		10.00
(-1.23%)		18.68
(53.54%)		📈 view plot
🚷 view threshold		139.00
(+0.80%)		142.96
(97.23%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24.55
(-0.65%)		25.18
(97.49%)		📈 view plot
🚷 view threshold		9.79
(-0.73%)		10.01
(97.77%)		📈 view plot
🚷 view threshold		13.79
(-0.85%)		14.17
(97.32%)		📈 view plot
🚷 view threshold		31.00
(-13.70%)		45.99
(67.40%)		📈 view plot
🚷 view threshold		303.00
(-0.17%)		313.27
(96.72%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30.18
(-0.48%)		30.72
(98.23%)		📈 view plot
🚷 view threshold		11.99
(-0.52%)		12.18
(98.39%)		📈 view plot
🚷 view threshold		16.96
(-0.62%)		17.29
(98.05%)		📈 view plot
🚷 view threshold		55.00
(-1.52%)		67.57
(81.39%)		📈 view plot
🚷 view threshold		370.00
(-0.27%)		379.15
(97.59%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126.42
(-0.03%)		126.78
(99.72%)		📈 view plot
🚷 view threshold		73.12
(-0.18%)		73.53
(99.44%)		📈 view plot
🚷 view threshold		104.76
(-0.23%)		105.50
(99.30%)		📈 view plot
🚷 view threshold		110.00
(+3.30%)		125.59
(87.58%)		📈 view plot
🚷 view threshold		603.00
(+0.90%)		609.82
(98.88%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27.78
(-0.47%)		28.39
(97.88%)		📈 view plot
🚷 view threshold		9.58
(-0.57%)		9.76
(98.13%)		📈 view plot
🚷 view threshold		13.52
(-0.69%)		13.84
(97.73%)		📈 view plot
🚷 view threshold		66.00
(+2.20%)		78.05
(84.57%)		📈 view plot
🚷 view threshold		398.00
(-0.32%)		409.61
(97.17%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115.16
(-0.07%)		115.71
(99.53%)		📈 view plot
🚷 view threshold		67.89
(-0.24%)		68.42
(99.23%)		📈 view plot
🚷 view threshold		97.36
(-0.30%)		98.28
(99.06%)		📈 view plot
🚷 view threshold		67.00
(+2.82%)		86.97
(77.04%)		📈 view plot
🚷 view threshold		499.00
(+1.17%)		504.13
(98.98%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23.16
(-0.73%)		23.82
(97.22%)		📈 view plot
🚷 view threshold		8.13
(-0.71%)		8.32
(97.75%)		📈 view plot
🚷 view threshold		11.43
(-0.81%)		11.75
(97.32%)		📈 view plot
🚷 view threshold		35.00
(-9.95%)		50.88
(68.79%)		📈 view plot
🚷 view threshold		330.00
(-0.49%)		342.25
(96.42%)
serialize_submit📈 view plot
🚷 view threshold		99.80
(+0.01%)		100.09
(99.71%)		📈 view plot
🚷 view threshold		61.33
(-0.21%)		61.73
(99.34%)		📈 view plot
🚷 view threshold		87.93
(-0.26%)		88.64
(99.20%)		📈 view plot
🚷 view threshold		49.00
(+2.27%)		66.47
(73.71%)		📈 view plot
🚷 view threshold		332.00
(+2.06%)		337.03
(98.51%)
serialize_subscribe📈 view plot
🚷 view threshold		11.40
(+0.03%)		11.60
(98.33%)		📈 view plot
🚷 view threshold		4.11
(-1.25%)		4.28
(95.98%)		📈 view plot
🚷 view threshold		5.69
(-1.58%)		6.00
(94.91%)		📈 view plot
🚷 view threshold		15.00
(+8.78%)		23.80
(63.03%)		📈 view plot
🚷 view threshold		161.00
(+1.60%)		164.28
(98.00%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🐰 Bencher Report

Branch2025-add-rust-toolchain
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		45.15
(-0.17%)		60.02
(75.22%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		72.48
(-6.44%)		107.47
(67.44%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.66
(+0.00%)		14.73
(99.57%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		265.16
(-0.14%)		288.40
(91.94%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		616.94
(+0.34%)		653.20
(94.45%)
client_sv2_open_channel📈 view plot
🚷 view threshold		163.04
(-1.78%)		179.74
(90.71%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		287.42
(+0.73%)		311.25
(92.34%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		388.69
(+1.67%)		400.98
(96.94%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		156.84
(-2.02%)		172.34
(91.01%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		492.42
(+4.45%)		559.37
(88.03%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		967.45
(-3.07%)		1,188.53
(81.40%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🐰 Bencher Report

Branch2025-add-rust-toolchain
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,512.30
(-0.88%)		6,939.11
(93.85%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,458.70
(+0.50%)		7,874.14
(94.72%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,040.10
(-0.89%)		9,411.79
(85.43%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		849.89
(-2.17%)		946.54
(89.79%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		666.50
(-1.20%)		717.71
(92.86%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		244.32
(-1.92%)		266.31
(91.74%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		161.32
(+2.19%)		167.77
(96.15%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,341.30
(-0.24%)		6,804.74
(93.19%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		280.07
(-1.20%)		327.92
(85.41%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		715.95
(-1.62%)		780.48
(91.73%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		585.17
(-1.19%)		626.13
(93.46%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		205.49
(-0.74%)		227.22
(90.44%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.29%. Comparing base (651f35a) to head (7836b55).

Additional details and impacted files 
@@            Coverage Diff             @@
##            main    #1335       +/-   ##
==========================================
+ Coverage   0.00%   19.29%   +19.29%     
==========================================
  Files         18      164      +146     
  Lines        982    10852     +9870     
==========================================
+ Hits           0     2094     +2094     
- Misses       982     8758     +7776
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (?)
binary_serde_sv2-coverage 3.65% <ø> (?)
binary_sv2-coverage 5.48% <ø> (?)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (?)
codec_sv2-coverage 0.01% <ø> (?)
common_messages_sv2-coverage 0.13% <ø> (?)
const_sv2-coverage 0.00% <ø> (?)
error_handling-coverage 0.00% <ø> (?)
framing_sv2-coverage 0.29% <ø> (?)
jd_client-coverage 0.00% <ø> (?)
jd_server-coverage 7.79% <ø> (?)
job_declaration_sv2-coverage 0.00% <ø> (?)
key-utils-coverage 2.39% <ø> (?)
mining-coverage 2.49% <ø> (?)
mining_device-coverage 0.00% <ø> (?)
mining_proxy_sv2-coverage 0.70% <ø> (?)
noise_sv2-coverage 4.35% <ø> (?)
pool_sv2-coverage 1.38% <ø> (?)
protocols 24.72% <ø> (?)
roles 6.54% <ø> (?)
roles_logic_sv2-coverage 8.08% <ø> (?)
sv2_ffi-coverage 0.00% <ø> (?)
template_distribution_sv2-coverage 0.00% <ø> (?)
translator_sv2-coverage 9.60% <ø> (?)
utils 25.13% <ø> (?)
v1-coverage 2.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbesraa
Copy link
Contributor

jbesraa commented Jan 8, 2025

nack, our formatting works with nightly and always was. Also, you didnt provide any example where your statement is correct, your pr was not formatted with nightly and thats why you had so many changes.

We had this discussion a couple of times already with adding/not the rust-toolchain file, not sure why we are back at it again.

@Shourya742
Copy link
Contributor Author

nack, our formatting works with nightly and always was. Also, you didnt provide any example where your statement is correct, your pr was not formatted with nightly and thats why you had so many changes.

We had this discussion a couple of times already with adding/not the rust-toolchain file, not sure why we are back at it again.

Not quite. While the code is formatted with nightly, the issue lies in the specific version of nightly used. My version, rustfmt 1.8.0-nightly (6d9f6ae36a 2024-12-16), differs from rustfmt 1.7.0-nightly (f067fd60 2024-02-05), which appears to be the version expected. This discrepancy is precisely why adding a rust-toolchain.toml file is beneficial—it ensures all contributors use the same Rust version and components, eliminating mismatches. Without this, differences in nightly versions can lead to unnecessary formatting changes, as seen here.

@jbesraa
Copy link
Contributor

jbesraa commented Jan 8, 2025

The workflow uses always latest nightly https://github.com/stratum-mining/stratum/blob/main/.github/workflows/fmt.yaml

@Shourya742
Copy link
Contributor Author

Shourya742 commented Jan 8, 2025 •
edited
Loading

The workflow uses always latest nightly https://github.com/stratum-mining/stratum/blob/main/.github/workflows/fmt.yaml

Not only the formatting but even clippy throws error locally when I run it, because of versioning.

181 - impl<'a> From<tokio::sync::broadcast::error::RecvError> for Error<'a> {
181 + impl From<tokio::sync::broadcast::error::RecvError> for Error<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> translator/src/lib/error.rs:188:6
    |
188 | impl<'a, T> From<PoisonError<T>> for Error<'a> {
    |      ^^                                    ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
188 - impl<'a, T> From<PoisonError<T>> for Error<'a> {
188 + impl<T> From<PoisonError<T>> for Error<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> translator/src/lib/error.rs:219:6
    |
219 | impl<'a> From<async_channel::SendError<v1::Message>> for Error<'a> {
    |      ^^                                                        ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
219 - impl<'a> From<async_channel::SendError<v1::Message>> for Error<'a> {
219 + impl From<async_channel::SendError<v1::Message>> for Error<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> translator/src/lib/error.rs:225:6
    |
225 | impl<'a> From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'a> {
    |      ^^                                                                      ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
225 - impl<'a> From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'a> {
225 + impl From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> translator/src/lib/error.rs:261:6
    |
261 | impl<'a> From<Vec<u8>> for Error<'a> {
    |      ^^                          ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
261 - impl<'a> From<Vec<u8>> for Error<'a> {
261 + impl From<Vec<u8>> for Error<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> translator/src/lib/error.rs:267:6
    |
267 | impl<'a> From<ParseLengthError> for Error<'a> {
    |      ^^                                   ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
267 - impl<'a> From<ParseLengthError> for Error<'a> {
267 + impl From<ParseLengthError> for Error<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> translator/src/lib/error.rs:273:6
    |
273 | impl<'a> From<SetDifficulty> for Error<'a> {
    |      ^^                                ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
273 - impl<'a> From<SetDifficulty> for Error<'a> {
273 + impl From<SetDifficulty> for Error<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> translator/src/lib/error.rs:279:6
    |
279 | impl<'a> From<std::convert::Infallible> for Error<'a> {
    |      ^^                                           ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
279 - impl<'a> From<std::convert::Infallible> for Error<'a> {
279 + impl From<std::convert::Infallible> for Error<'_> {
    |

error: could not compile `translator_sv2` (lib) due to 18 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `jd_client` (lib) due to 14 previous errors

I remember one of the new contributors added these clippy mentioned changes in his PR.

@plebhash
Copy link
Collaborator

plebhash commented Jan 8, 2025

let's investigate on the need for using nightly on fmt CI and see how we can make progress on this

Georges760
Georges760 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Georges760 Georges760 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made myself almost the exact same file in order to have my shell.nix synced with toolchain version

@plebhash plebhash mentioned this pull request Jan 8, 2025
Closed
@GitGab19
Copy link
Collaborator

GitGab19 commented Feb 3, 2025

Is this still needed?

I haven't followed the discussion opened after this.

I would say it's not needed and we can close this PR, but I just want to be sure before proceeding.

@Shourya742
Copy link
Contributor Author

Is this still needed?

I haven't followed the discussion opened after this.

I would say it's not needed and we can close this PR, but I just want to be sure before proceeding.

Wating for @rrybarczyk , #1333 (comment)

@jbesraa
Copy link
Contributor

jbesraa commented Feb 3, 2025

still big nack from me, I dont see any reason for this. whats described in #1333 happened (maybe) once and I think that was a problem with the authors text editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Georges760 Georges760 Georges760 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rust-toolchain.toml
5 participants
@Shourya742 @jbesraa @plebhash @GitGab19 @Georges760