simplify [package.metadata.docs.rs] on remaining crates
#1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
=======================================
Coverage 19.08% 19.08%
=======================================
Files 166 166
Lines 11066 11066
=======================================
Hits 2112 2112
Misses 8954 8954
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Shourya742
suggested changes
Jan 21, 2025
There was a problem hiding this comment.
As now nebula's codec std pr is merged: #1346. We can add std to features in codec [package.metadata.docs.rs].
plebhash
force-pushed
the
cleanup-all-features
branch
from
05ef70a to
a1a2fd9
Compare
publishing with all-features is overengineering: - with_serde will be deprecated soon - for crates with relevant features, we specifically list them for publishing
plebhash
force-pushed
the
cleanup-all-features
branch
from
a1a2fd9 to
757b9ef
Compare
GitGab19
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1318
I missed a few crates, which would be good to have a cleanup before we proceed with #1313
also
noise_sv2received a new feature via #1238