Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move interop-cpp examples to sv2-ffi crate #1407

Closed
wants to merge 1 commit into from

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Jan 27, 2025

similar to #1404

this PR moves the interop-cpp examples to sv2-ffi crate

builds on top of #1405

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.05%. Comparing base (c605e0d) to head (35acbe7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1407      +/-   ##
==========================================
- Coverage   19.08%   19.05%   -0.03%     
==========================================
  Files         166      167       +1     
  Lines       11066    11081      +15     
==========================================
  Hits         2112     2112              
- Misses       8954     8969      +15     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.54% <ø> (-0.02%) ⬇️
binary_sv2-coverage 5.33% <ø> (-0.02%) ⬇️
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (-0.01%) ⬇️
common_messages_sv2-coverage 0.13% <ø> (-0.01%) ⬇️
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (-0.01%) ⬇️
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.42% <ø> (-0.01%) ⬇️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.43% <ø> (-0.02%) ⬇️
pool_sv2-coverage 2.04% <ø> (ø)
protocols 24.52% <ø> (-0.06%) ⬇️
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 7.91% <ø> (-0.03%) ⬇️
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (?)
v1-coverage 2.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GitGab19 GitGab19 added the ready-to-be-merged triggers auto rebase bot label Jan 29, 2025
@pavlenex pavlenex force-pushed the move-cpp-examples branch 2 times, most recently from fa8429e to f9f5367 Compare January 29, 2025 12:42
@plebhash
Copy link
Collaborator Author

turns out that adapting the scripts is not as simple as I initially thought

not sure this is worth spending time now, so I'll just close this PR

@plebhash plebhash closed this Jan 29, 2025
@plebhash plebhash removed the ready-to-be-merged triggers auto rebase bot label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants