test: Add test for lazy connection filtering issue #539
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Eraldo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
tests/relay/test_fields.py
Outdated
| @@ -1175,3 +1177,22 @@ def test_query_connection_total_count_sql_queries( | |||
| assert result.data == { | |||
| query_attr: {"totalCount": 5}, | |||
| } | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="TODO: Fix issue => https://github.com/strawberry-graphql/strawberry-django/issues/535") | |||
There was a problem hiding this comment.
suggestion (testing): Consider adding a test for the issue once it is fixed
While the test is currently skipped due to the issue, it would be beneficial to add a test case that verifies the fix once the issue is resolved. This will ensure that the problem does not reoccur in the future.
| @pytest.mark.skip(reason="TODO: Fix issue => https://github.com/strawberry-graphql/strawberry-django/issues/535") | |
| @pytest.mark.skip(reason="TODO: Fix issue => https://github.com/strawberry-graphql/strawberry-django/issues/535") | |
| def test_query_lazy_connection_with_filters(db): | |
| color = Color.objects.create(name="Magenta") | |
| @pytest.mark.skipif(not issue_535_fixed(), reason="Issue 535 not fixed yet") | |
| def test_query_lazy_connection_with_filters_fixed(db): | |
| color = Color.objects.create(name="Magenta") |
| } | ||
| } | ||
| """ | ||
| result = schema.execute_sync(query=query) |
There was a problem hiding this comment.
suggestion (testing): Check for expected data in the result
Currently, the test only checks for the absence of errors. It would be more robust to also verify that the returned data matches the expected structure and values. This ensures that the query not only executes without errors but also returns the correct data.
| result = schema.execute_sync(query=query) | |
| result = schema.execute_sync(query=query) | |
| assert result.errors is None | |
| expected_data = { | |
| # Add the expected structure and values here | |
| } | |
| assert result.data == expected_data |
| Fruit.objects.create(name="Apple", color=color) | ||
| query = """ | ||
| query TestQuery { | ||
| colorWithLazyFruits(filters: {}) { |
There was a problem hiding this comment.
I'm checking here and this is not supposed to have filters. What is supposed to have filters is fruits, and in my tests it seems to have
|
Going to close this as it is not actually reproducing the issue. |
#535
Description
Added reproduction test for #535
I marked the test ask skipped until a fix is in place. ;)
Types of Changes
Issues Fixed or Closed by This PR