-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated fields type resolution #565
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d922bd2
Handle resolution of generated field type
Mapiarz 25bdc14
Handle detection of optionality of generated fields
Mapiarz 177add4
Extend existing test to cover generated fields
Mapiarz 603b518
Avoid using |
Mapiarz 690353a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 10b9656
Make some typing errors go away
Mapiarz adee326
Disable ruff check for private import
Mapiarz b6f1cb5
PR review fixes
Mapiarz 1a146c6
Pyright fixes
Mapiarz 8eca3dc
Apply suggestions from code review
bellini666 e1ff560
fix: Add missing django import
bellini666 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding a comment here that
GeneratedField
is only available at Django 5.0+ so that we remember to remove it when dropping support for 4.2 in the future?Another suggestion would be to change this to:
This is self-documented, and is the kind of string that I would search for when searching for code that can be dropped/simplified after a version bump