-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for auto mapping of ArrayFields #567
Conversation
Reviewer's Guide by SourceryThis pull request adds support for auto mapping of ArrayFields in Django models. The implementation includes importing File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 5 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
+ Coverage 88.85% 88.88% +0.03%
==========================================
Files 41 41
Lines 3544 3545 +1
==========================================
+ Hits 3149 3151 +2
+ Misses 395 394 -1 ☔ View full report in Codecov by Sentry. |
Fix #200
Summary by Sourcery
This pull request introduces support for auto mapping of ArrayFields in Django models, including handling for both single-dimensional and multi-dimensional arrays. It also adds corresponding tests to ensure the correct type resolution and functionality.