-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump strawberry to 0.236.0 and refactor changed imports #591
Conversation
Reviewer's Guide by SourceryThis pull request updates the import paths across multiple files to align with the changes introduced in strawberry 0.236.0. The changes are primarily focused on refactoring the import statements to use the new module structure provided by the updated strawberry library. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
+ Coverage 88.82% 88.84% +0.01%
==========================================
Files 41 41
Lines 3598 3604 +6
==========================================
+ Hits 3196 3202 +6
Misses 402 402 ☔ View full report in Codecov by Sentry. |
Thanks for the quick reaction to the strawberry version update. One question though: You might say hey just use a lockfile. However, some people just use the django cookiecutter template and that doesn't have lockfiles (maybe it should I don't know) and just define the dependencies in requirements.txt and use those in the docker build setup. Thanks for your efforts! |
@Elio-Nakhle I think here I was at fault for not submitting a PR to this repo, the idea is to keep strawberry and strawberry django in sync (maybe we should have a ci test for that too), in fact the codemod I did was tested on this repo 😊 I think it's a good tradeoff to have this library not pin strawberry, as we usually don't do breaking changes like this. Pinning it would mean that Thiago would need to make a release every time we do a release too, which is not ideal 😊 |
d80ec3b
to
d0fcf30
Compare
Changes required for https://github.com/strawberry-graphql/strawberry/releases/tag/0.236.0
Fix #590
Summary by Sourcery
This pull request updates the import paths in various files to be compatible with the changes introduced in Strawberry 0.236.0. This ensures that the project remains functional and up-to-date with the latest version of the Strawberry library.