Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player controls position switch #1557

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Christian-Kr
Copy link
Contributor

Hello again,

I would like to have a position switch for the player controls (including the status information with the slider). I am sure this might lead to some discussion because of bigger ui changes.

I placed the setting for it inside the appearance settings dialog and also removed the vertical (for me not needed) line at the left side of the player controls.

You can toggle the position of the player controls widget between top and bottom.

INFO: I will squash the commits before final approvement. Till then I wanted to keep my commit structure alive for any further changes.

Thanks for your time. :-)

Greetings

@Christian-Kr
Copy link
Contributor Author

Hello,

I wanted to ask, when do you think, you got time for this pr. Just in case it will be accepted, I wanted to know, when this will happen.

I have another short question, which might be a little more general and is not limited to this software:

A lot of open source developers are short on resources (time). What is the best practice to get involved and support? If I need to get into the source code of a software and can only proof myself by implementing features and/or solve a bug which needs a pr, wouldn't this again limit a project in finding people taking responsibility and support a software? Because the developer does not have the time to work on pr. So in such a case, shouldn't the work on pr have a high priority? (Again, it is not a complain about this pr but a general question.)

Thanks in advance.
Greetings Christian

@jonaski
Copy link
Member

jonaski commented Oct 26, 2024

Sorry but I'm not sure I want this change, I think this looks out of place moving not only the buttons, but everything including the bottom status and analyzer.

@Christian-Kr
Copy link
Contributor Author

Sure. Not a problem. What would be a better way for you? I can change the implementation.

I would like to have the buttons and the time-bar (slider) above the playlist. Everything else might still be at the bottom.

If you want me to, I can change the implementation to put the buttons, the visualizer and the slider to the top and leave the rest at the bottom. Than you can have a look at the results.

Just give me a short hint, please.

Thx in advance for all your work.
Greetings

@rabyj
Copy link

rabyj commented Oct 28, 2024

@Christian-Kr You might have to maintain your own mirror fork if you want a different specific UI version. I don't think major changes like that will pass easily to the main repo.

Are all your proposed changes toggleable easily? If they are, I don't see clearly why it would be a problem to have one more option that's not a default @jonaski.

Sorry if I'm speaking out of turn, I just love this player and Christian seems to potentially want to give time to this project, if I understood correctly?

Cheers!

@Christian-Kr
Copy link
Contributor Author

@Christian-Kr You might have to maintain your own mirror fork if you want a different specific UI version. I don't think major changes like that will pass easily to the main repo.

Yes. But I always try to no fork some software. (A real fork, not this temporary github thing...)

Are all your proposed changes toggleable easily? If they are, I don't see clearly why it would be a problem to have one more option that's not a default @jonaski.

It is toggleable. But this is also a philosphy. Some people want to have few options making the ui clear and simple and others like to have multiple options. I personally prefer more options (that's why I use kde... :-D).

Sorry if I'm speaking out of turn, I just love this player and Christian seems to potentially want to give time to this project, if I understood correctly?

Just in case I have the time and want something that is not available yet, or some annoying bug pops up. :-) Like many others I don't have the time for full maintenance service. Sorry.

Cheers!

@jonaski
Copy link
Member

jonaski commented Nov 2, 2024

This is how it looks:

image

@Christian-Kr
Copy link
Contributor Author

It can also look like this, if you want to. The track information will still be on the bottom, while the other elements will be moved to the top.

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants