Bump windows-core to 0.53-0.54 range
#131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the necessary binding changes for compatibility, provided by `windows-bindgen 0.53-0.54`. Generated code by `windows-bindgen` now also expects `TryInto` to be in scope via Rust's `prelude`, which is only the case in Rust edition `2021`.
MarijnS95
added a commit
to MarijnS95/iana-time-zone
that referenced
this pull request
Mar 26, 2024
Note that `windows 0.55` was not released, and any implementation in the wild depending on `windows` will get `windows-core 0.54` in their dependency tree for obvious compatibility reasons, and would get a duplicate if `iana-time-zone` decides to switch to o`windows-core 0.55` prematurely. This PR depends on strawlab#131 and can be updated and merged whenever there is a compelling reason to bump further. This requires a strange change to remove a "comment" from `bindings.txt`: Running `api_gen/target/debug/api_gen` Error: Error { message: "unused filters\n Dependencies\n above\n the\n of\n #", path: "", span: None }
MarijnS95
added a commit
to MarijnS95/iana-time-zone
that referenced
this pull request
Mar 26, 2024
Note that `windows 0.55` was not released, and any implementation in the wild depending on `windows` will get `windows-core 0.54` in their dependency tree for obvious compatibility reasons, and would get a duplicate if `iana-time-zone` decides to switch to o`windows-core 0.55` prematurely. This PR depends on strawlab#131 and can be updated and merged whenever there is a compelling reason to bump further. This requires a strange change to remove a "comment" from `bindings.txt`: Running `api_gen/target/debug/api_gen` Error: Error { message: "unused filters\n Dependencies\n above\n the\n of\n #", path: "", span: None }
|
Bumping the edition for having |
|
@astraw I don't see any strategy as to what the policy is regarding MSRV bumps in https://github.com/strawlab/iana-time-zone?tab=readme-ov-file#minimum-supported-rust-version-policy, and it seems likely that an internal version bump for a newer crate that doesn't provide any useful/fixed functionality otherwise (besides getting rid of duplicate deps downstream) isn't very compelling to break MSRV for. Despite that, what are your thoughts? The requested version here for |
Kijewski
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the necessary binding changes for compatibility, provided by
windows-bindgen 0.53-0.54. Generated code bywindows-bindgennow also expectsTryIntoto be in scope via Rust'sprelude, which is only the case in Rust edition2021.