Add stream service destroy #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'destroy' method to service classes. Revert "Add destroy method to test file." This reverts commit 13db2b7. Add 'destroy' to test file.
|
|
mhoyer-streamlabs
force-pushed
the
add_stream_service_destroy
branch
from
29b3eb1 to
cb61754
Compare
summeroff
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Classes obs-studio-client/service and obs-studio-server/osn-service need 'destroy' methods to clean up the streaming services when no longer needed.
Motivation and Context
How Has This Been Tested?
Include the new method in test-osn-service.ts.
Types of changes
Tweak (non-breaking change to improve existing functionality)
Checklist: