Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add logs for StreamLabs API errors #47

Closed
wants to merge 8 commits into from
Closed

feat: Add logs for StreamLabs API errors #47

wants to merge 8 commits into from

Conversation

orestes
Copy link
Collaborator

@orestes orestes commented Apr 13, 2020

Resolves #45

@orestes orestes requested a review from SantiMA10 April 13, 2020 22:55
@orestes orestes changed the title 45 log streamlabs errors feat: Add logs for StreamLabs API errors Apr 13, 2020
@orestes orestes closed this Apr 13, 2020
@orestes orestes deleted the 45-log-streamlabs-errors branch April 13, 2020 23:36
@orestes
Copy link
Collaborator Author

orestes commented Apr 13, 2020 •
edited
Loading

This was a cursed issue. Trying to exorcise it now 🤞

@orestes orestes reopened this Apr 13, 2020
SantiMA10
SantiMA10 requested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@SantiMA10 SantiMA10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments 😜

src/services/StreamLabs.js Show resolved Hide resolved
src/services/StreamLabs.js Show resolved Hide resolved
src/routes/github/index.js Outdated Show resolved Hide resolved
test/services/StreamLabs.spec.js Outdated Show resolved Hide resolved
@SantiMA10
Copy link
Contributor

SantiMA10 commented Apr 14, 2020 •
edited
Loading

@orestes the CI is working now, you only have to fix the format 😉

@orestes orestes requested a review from SantiMA10 April 14, 2020 22:49
SantiMA10
SantiMA10 approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@SantiMA10 SantiMA10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just resolve the conflicts!

@orestes orestes closed this Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantiMA10 SantiMA10 SantiMA10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debugging HTTP 401 responses from StreamLabs
2 participants
@orestes @SantiMA10