fix(useFullscreen):accept nullable ref and add minimal test #2670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2662
Overview
This PR fixes a type-safety issue in
useFullscreen
and adds a minimal test to ensure basic functionality.Description
useFullscreen
currently expectsRefObject<HTMLElement>
which is not compatible with React'suseRef
/createRef
that can be null. This PR changes the type toRefObject<HTMLElement | null>
. Also added a small cast in the catch block for better TypeScript safety.Type of change
src/useFullscreen.ts
:ref
parameterError
(onClose(error as Error)
)tests/useFullscreen.test.ts
:Checklist
yarn test
)yarn lint
). Fix it withyarn lint:fix
in case of failure.yarn lint:types
).