Skip to content

Commit

Permalink
Whoops, skip segments that are before the FirstIndex of a module, not…
Browse files Browse the repository at this point in the history
… the reverse.
  • Loading branch information
Alexandre Bourget committed Jul 3, 2023
1 parent 72ad2e5 commit ed46cb3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion orchestrator/stage/squash.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func (s *Stages) multiSquash(stage *Stage, mergeUnit Unit) error {

// Launch parallel jobs to merge all stages' stores.
for _, modState := range stage.moduleStates {
if modState.segmenter.FirstIndex() < mergeUnit.Segment {
if mergeUnit.Segment < modState.segmenter.FirstIndex() {
continue
}

Expand All @@ -50,6 +50,7 @@ func (s *Stages) multiSquash(stage *Stage, mergeUnit Unit) error {
// We keep the cache of the latest FullKV store, to speed up things
// if they are linear
func (s *Stages) singleSquash(stage *Stage, modState *ModuleState, mergeUnit Unit) error {
fmt.Println("running singleSquash", mergeUnit)
metrics := mergeMetrics{}
metrics.start = time.Now()

Expand Down
2 changes: 1 addition & 1 deletion test/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ func TestOneStoreOneMap(t *testing.T) {
for idx, test := range tests {
t.Run(test.name, func(t *testing.T) {
if idx < 2 {
// FIXME: remove this skipp
// FIXME: remove this skip
t.Skip("skipped")
}

Expand Down

0 comments on commit ed46cb3

Please sign in to comment.