Bugfix/metering #517
Open
Bugfix/metering #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abourget
reviewed
Aug 14, 2024
| "written_bytes": float64(bytesWritten), | ||
| "read_bytes": float64(bytesRead), | ||
| "wasm_input_bytes": float64(inputBytes), | ||
| "message_count": 1, |
There was a problem hiding this comment.
y'avait-il pas déjà une convention d'avoir l'unité à la fin? donc uncompressed_read_bytes plutôt que uncompressed_bytes_read ?
There was a problem hiding this comment.
good point, i will make the change
abourget
reviewed
Aug 14, 2024
|
|
||
| return streamHandler.ProcessBlock(blk, obj) | ||
| }) | ||
|
|
There was a problem hiding this comment.
ok, donc le tier2 va lire des blocks, et ici c'est la source elle-même qui va être metered, avec des métriques différentes, fack on fera l'aggrégation à la sortie, correct?
There was a problem hiding this comment.
the tier2 doesn't play into this. tier2 does not have live blocks and so the blockstream doesn't need to be instrumented. all of the tier2's data sources are dstores which are metered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plan to fix metering: