Skip to content

Commit

Permalink
Support Istio migration mode (#1116)
Browse files Browse the repository at this point in the history
* Make mtls mode permissive for Istio migration

* Apply to slim

(cherry picked from commit 1b38177)
  • Loading branch information
ciiiii authored and ericsyh committed Oct 31, 2023
1 parent a932c96 commit 6203426
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 0 deletions.
4 changes: 4 additions & 0 deletions charts/sn-platform-slim/templates/broker/broker-cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,10 @@ spec:
{{- if and .Values.istio.enabled .Values.ingress.broker.enabled }}
istio:
enabled: true
{{- if .Values.istio.migration }}
mtls:
mode: permissive
{{- end }}
gateway:
selector:
{{- include "pulsar.istio.gateway.selector" . | indent 8 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,9 @@ metadata:
namespace: {{ template "pulsar.namespace" . }}
spec:
mtls:
{{- if .Values.istio.migration }}
mode: PERMISSIVE
{{- else }}
mode: STRICT
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions charts/sn-platform-slim/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2092,6 +2092,7 @@ extraResources: []

istio:
enabled: false
migration: false
# istio labels used to inject sidecars if it's not `sidecar.istio.io/inject: "true"`
labels: {}
# If you're using the prometheus in this chart, please keep mergeMetrics disabled.
Expand Down
4 changes: 4 additions & 0 deletions charts/sn-platform/templates/broker/broker-cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ spec:
{{- if and .Values.istio.enabled .Values.ingress.broker.enabled }}
istio:
enabled: true
{{- if .Values.istio.migration }}
mtls:
mode: permissive
{{- end }}
gateway:
selector:
{{- include "pulsar.istio.gateway.selector" . | indent 8 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,9 @@ metadata:
namespace: {{ template "pulsar.namespace" . }}
spec:
mtls:
{{- if .Values.istio.migration }}
mode: PERMISSIVE
{{- else }}
mode: STRICT
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions charts/sn-platform/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2454,6 +2454,7 @@ custom_metric_server:

istio:
enabled: false
migration: false
# istio labels used to inject sidecars if it's not `sidecar.istio.io/inject: "true"`
labels: {}
# If you're using the prometheus in this chart, please keep mergeMetrics disabled.
Expand Down

0 comments on commit 6203426

Please sign in to comment.