feat: add extraArgs for detector

Signed-off-by: ericsyh <[email protected]>
streamnative · Nov 9, 2023 · e806b0a · e806b0a
1 parent 5792b4f
commit e806b0a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/charts/sn-platform-slim/templates/detector/pulsar-detector-deployment.yaml b/charts/sn-platform-slim/templates/detector/pulsar-detector-deployment.yaml
@@ -109,9 +109,20 @@ spec:
         image: "{{ .Values.images.pulsar_detector.repository }}:{{ .Values.images.pulsar_detector.tag }}"
         imagePullPolicy: {{ .Values.images.pulsar_detector.pullPolicy }}
         command: ["sh", "-c"]
+        {{- if .Values.pulsar_detector.extraArgs }}
         args:
         - >
-          bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if .Values.auth.authentication.enabled }} -auth-plugin token -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" {{- end }} {{- if .Values.pulsar_detector.extraArgs }} {{.Values.pulsar_detector.extraArgs }} {{- end }};
+          bin/pulsar-detector \
+          {{- range $key, $value := .Values.pulsar_detector.extraArgs }}
+          -{{ $key }} {{ $value }} \
+          {{- end }}
+          -service-url {{ template "pulsar.detector.serviceUrl" . }} \
+          -webservice-url {{ template "pulsar.detector.webServiceUrl" . }}};
+        {{- else }}
+        args:
+        - >
+          bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if .Values.auth.authentication.enabled }} -auth-plugin token -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" {{- end }};
+        {{- end }}
         {{- if .Values.pulsar_detector.resources }}
         resources: {{- toYaml .Values.pulsar_detector.resources | nindent 10 }}
         {{- end }}

diff --git a/charts/sn-platform-slim/values.yaml b/charts/sn-platform-slim/values.yaml
@@ -1403,6 +1403,11 @@ pulsar_detector:
   extraVolumes: []
   extraVolumeMounts: []
   extraEnv: []
+  ## Additional pulsar_detector container arguments
+  extraArgs: {}
+    # Configure the tls auth for detector
+    # auth-plugin: "tls"
+    # auth-params: "{\"tlsCertFile\":\"val1\"}"
   ## Proxy service
   ## templates/pulsar-detector-service.yaml
   ##