Load the pulsar env as the program start options #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- ### Motivation When enable tls for the zookeeper, it will write the TLS properties with PULSAR_EXTRA_OPTS as the key into the pulsar-env.sh file. The metadata tool also needs the PULSAR_EXTRA_OPTS to get the zookeeper TLS configurations. So import the PULSAR_EXTRA_OPTS into the OPTS to load the zookeeper TLS configuration.
|
@zymap:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
ericsyh
approved these changes
Oct 13, 2023
ericsyh
pushed a commit
that referenced
this pull request
Oct 16, 2023
--- ### Motivation When enable tls for the zookeeper, it will write the TLS properties with PULSAR_EXTRA_OPTS as the key into the pulsar-env.sh file. The metadata tool also needs the PULSAR_EXTRA_OPTS to get the zookeeper TLS configurations. So import the PULSAR_EXTRA_OPTS into the OPTS to load the zookeeper TLS configuration. (cherry picked from commit b2c64d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When enable tls for the zookeeper, it will write the TLS properties with PULSAR_EXTRA_OPTS as the key into the pulsar-env.sh file. The metadata tool also needs the PULSAR_EXTRA_OPTS to get the zookeeper TLS configurations. So import the PULSAR_EXTRA_OPTS into the OPTS to load the zookeeper TLS configuration.