Skip to content

Commit

Permalink
Change field processingGuarantee to processingGuarantees for WindowCo…
Browse files Browse the repository at this point in the history
…nfig
  • Loading branch information
jiangpengcheng committed Nov 25, 2024
1 parent ca2806b commit 45b2d2a
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 5 deletions.
7 changes: 7 additions & 0 deletions .ci/tests/integration/cases/logging-window-function/verify.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ if [ $? -ne 0 ]; then
exit 1
fi

# verify the `processingGuarantees` config
kubectl logs window-function-sample | grep processingGuarantees=ATLEAST_ONCE
if [ $? -ne 0 ]; then
kubectl delete -f "${manifests_file}" > /dev/null 2>&1 || true
exit 1
fi

verify_java_result=$(NAMESPACE=${PULSAR_NAMESPACE} CLUSTER=${PULSAR_RELEASE_NAME} ci::send_test_data "persistent://public/default/window-function-input-topic" "test-message" 3 2>&1)
if [ $? -ne 0 ]; then
echo "$verify_java_result"
Expand Down
2 changes: 1 addition & 1 deletion api/compute/v1alpha1/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ type WindowConfig struct {
MaxLagMs *int64 `json:"maxLagMs,omitempty"`
WatermarkEmitIntervalMs *int64 `json:"watermarkEmitIntervalMs,omitempty"`
TimestampExtractorClassName *string `json:"timestampExtractorClassName,omitempty"`
ProcessingGuarantee WindowProcessGuarantee `json:"processingGuarantee,omitempty"`
ProcessingGuarantees WindowProcessGuarantee `json:"processingGuarantees,omitempty"`
}

type VPASpec struct {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3786,7 +3786,7 @@ spec:
maxLagMs:
format: int64
type: integer
processingGuarantee:
processingGuarantees:
enum:
- ATLEAST_ONCE
- ATMOST_ONCE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3805,7 +3805,7 @@ spec:
maxLagMs:
format: int64
type: integer
processingGuarantee:
processingGuarantees:
enum:
- ATLEAST_ONCE
- ATMOST_ONCE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3786,7 +3786,7 @@ spec:
maxLagMs:
format: int64
type: integer
processingGuarantee:
processingGuarantees:
enum:
- ATLEAST_ONCE
- ATMOST_ONCE
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/compute.functionmesh.io_functions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3783,7 +3783,7 @@ spec:
maxLagMs:
format: int64
type: integer
processingGuarantee:
processingGuarantees:
enum:
- ATLEAST_ONCE
- ATMOST_ONCE
Expand Down

0 comments on commit 45b2d2a

Please sign in to comment.