Add pod field

streamnative · Jul 2, 2024 · edc3ba2 · edc3ba2
1 parent 0d53e8e
commit edc3ba2
Show file tree

Hide file tree

Showing 8 changed files with 88 additions and 47 deletions.
diff --git a/.ci/clusters/global_backend_config.yaml b/.ci/clusters/global_backend_config.yaml
@@ -6,6 +6,7 @@ spec:
   env:
     global1: globalvalue1
     shared1: fromglobal
-  liveness:
-    initialDelaySeconds: 10
-    periodSeconds: 30
+  pod:
+    liveness:
+      initialDelaySeconds: 10
+      periodSeconds: 30
diff --git a/.ci/tests/integration/cases/global-and-namespaced-config/mesh-config-kube-system.yaml b/.ci/tests/integration/cases/global-and-namespaced-config/mesh-config-kube-system.yaml
@@ -7,6 +7,7 @@ spec:
   env:
     namespaced1: namespacedvalue1
     shared1: fromnamespace
-  liveness:
-    initialDelaySeconds: 50
-    periodSeconds: 60
+  pod:
+    liveness:
+      initialDelaySeconds: 50
+      periodSeconds: 60
diff --git a/.ci/tests/integration/cases/global-and-namespaced-config/mesh-config.yaml b/.ci/tests/integration/cases/global-and-namespaced-config/mesh-config.yaml
@@ -7,6 +7,7 @@ spec:
   env:
     namespaced1: namespacedvalue1
     shared1: fromnamespace
-  liveness:
-    initialDelaySeconds: 30
-    periodSeconds: 10
+  pod:
+    liveness:
+      initialDelaySeconds: 30
+      periodSeconds: 10
diff --git a/api/compute/v1alpha1/backendconfig_types.go b/api/compute/v1alpha1/backendconfig_types.go
@@ -34,6 +34,13 @@ type BackendConfigSpec struct {
 	// +kubebuilder:validation:Optional
 	Env map[string]string `json:"env,omitempty"`
 
+	// +kubebuilder:validation:Optional
+	Pod *BackendConfigPodPolicy `json:"pod,omitempty"`
+}
+
+// BackendConfigPodPolicy defines the policy for the pod
+// TODO: Support more fields from PodPolicy
+type BackendConfigPodPolicy struct {
 	// +kubebuilder:validation:Optional
 	Liveness *Liveness `json:"liveness,omitempty"`
 }

diff --git a/api/compute/v1alpha1/zz_generated.deepcopy.go b/api/compute/v1alpha1/zz_generated.deepcopy.go
diff --git a/...erator/charts/admission-webhook/templates/crd-compute.functionmesh.io-backendconfigs.yaml b/...erator/charts/admission-webhook/templates/crd-compute.functionmesh.io-backendconfigs.yaml
@@ -52,23 +52,26 @@ spec:
                   additionalProperties:
                     type: string
                   type: object
-                liveness:
-                  properties:
-                    failureThreshold:
-                      format: int32
-                      type: integer
-                    initialDelaySeconds:
-                      format: int32
-                      type: integer
-                    periodSeconds:
-                      format: int32
-                      type: integer
-                    successThreshold:
-                      format: int32
-                      type: integer
-                  type: object
                 name:
                   type: string
+                pod:
+                  properties:
+                    liveness:
+                      properties:
+                        failureThreshold:
+                          format: int32
+                          type: integer
+                        initialDelaySeconds:
+                          format: int32
+                          type: integer
+                        periodSeconds:
+                          format: int32
+                          type: integer
+                        successThreshold:
+                          format: int32
+                          type: integer
+                      type: object
+                  type: object
               type: object
             status:
               type: object

diff --git a/config/crd/bases/compute.functionmesh.io_backendconfigs.yaml b/config/crd/bases/compute.functionmesh.io_backendconfigs.yaml
@@ -30,23 +30,26 @@ spec:
                 additionalProperties:
                   type: string
                 type: object
-              liveness:
-                properties:
-                  failureThreshold:
-                    format: int32
-                    type: integer
-                  initialDelaySeconds:
-                    format: int32
-                    type: integer
-                  periodSeconds:
-                    format: int32
-                    type: integer
-                  successThreshold:
-                    format: int32
-                    type: integer
-                type: object
               name:
                 type: string
+              pod:
+                properties:
+                  liveness:
+                    properties:
+                      failureThreshold:
+                        format: int32
+                        type: integer
+                      initialDelaySeconds:
+                        format: int32
+                        type: integer
+                      periodSeconds:
+                        format: int32
+                        type: integer
+                      successThreshold:
+                        format: int32
+                        type: integer
+                    type: object
+                type: object
             type: object
           status:
             type: object

diff --git a/controllers/spec/common.go b/controllers/spec/common.go
@@ -20,6 +20,7 @@ package spec
 import (
 	"bytes"
 	"context"
+
 	// used for template
 	_ "embed"
 	"encoding/json"
@@ -306,8 +307,10 @@ func PatchStatefulSet(ctx context.Context, cli client.Client, namespace string,
 			for key, val := range globalBackendConfig.Spec.Env {
 				envData[key] = val
 			}
-			if globalBackendConfig.Spec.Liveness != nil {
-				liveness = globalBackendConfig.Spec.Liveness
+			if globalBackendConfig.Spec.Pod != nil {
+				if globalBackendConfig.Spec.Pod.Liveness != nil {
+					liveness = globalBackendConfig.Spec.Pod.Liveness
+				}
 			}
 		}
 	}
@@ -329,8 +332,10 @@ func PatchStatefulSet(ctx context.Context, cli client.Client, namespace string,
 			for key, val := range namespacedBackendConfig.Spec.Env {
 				envData[key] = val
 			}
-			if namespacedBackendConfig.Spec.Liveness != nil {
-				liveness = namespacedBackendConfig.Spec.Liveness
+			if namespacedBackendConfig.Spec.Pod != nil {
+				if namespacedBackendConfig.Spec.Pod.Liveness != nil {
+					liveness = namespacedBackendConfig.Spec.Pod.Liveness
+				}
 			}
 		}
 	}