Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync proto #637

Merged
merged 2 commits into from
May 15, 2023
Merged

Sync proto #637

merged 2 commits into from
May 15, 2023

Conversation

jiangpengcheng
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #636

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Sync with latest Function.proto

Modifications

  1. Add Manual delivery semantics to function, sink, source
  2. Add CompressionType to function, source
  3. add SkipToLatest to function

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners May 10, 2023 02:03
@github-actions github-actions bot added the doc-required This pr needs a document label May 10, 2023
@nlu90
Copy link
Contributor

nlu90 commented May 11, 2023

Will this proto-change cause breaking behavior?
If this is the case, then we need to clearly mark version requirement

@jiangpengcheng
Copy link
Member Author

jiangpengcheng commented May 12, 2023

Will this proto-change cause breaking behavior? If this is the case, then we need to clearly mark version requirement

I tested that this pr has requirements of runner images' version:

  1. Manual delivery semantics: only supports runner image >= 2.11
  2. CompressionType field: only supports runner image >= 3.0.0
  3. SkipToLatest field: only supports runner image >=3.0.0

If users don't set those values, they won't be passed to runner pods, and there will be no error, so we only need to update the doc for those fields and specify the version requirement.

cc @Huanli-Meng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support "MANUAL" processing guarantee
3 participants