Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classpath to make it compatible with old runner image #789

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jiangpengcheng
Copy link
Member

@jiangpengcheng jiangpengcheng commented Nov 6, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

The #787 is using /pulsar/instances/deps/* in classpath, but old java runner images doesn't have dataformat-jackson-dataformat-yaml related jar in the /pulsar/instances/deps/* dir, so they won't able to use yaml type log4j configs, this PR fixes this issue

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners November 6, 2024 01:42
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Nov 6, 2024
@jiangpengcheng jiangpengcheng merged commit 3c92372 into master Nov 7, 2024
12 of 14 checks passed
@jiangpengcheng jiangpengcheng deleted the update_class_path_for_compatibility branch November 7, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants