default value should be null

streamnative · Jan 3, 2023 · 4cda499 · 4cda499
1 parent db9015b
commit 4cda499
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/...ctions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceStarter.java b/...ctions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceStarter.java
@@ -655,20 +655,20 @@ private void validateRequiredConfigs() {
      */
     private void useDefaultValueIfBothFileAndJCommanderNotProvided() {
 
-        jarFile = useSecondIfFirstIsNull(jarFile, "");
-        transformFunctionJarFile = useSecondIfFirstIsNull(transformFunctionJarFile, "");
-        transformFunctionId = useSecondIfFirstIsNull(transformFunctionId, "");
-        clientAuthenticationPlugin = useSecondIfFirstIsNull(clientAuthenticationPlugin, "");
-        clientAuthenticationParameters = useSecondIfFirstIsNull(clientAuthenticationParameters, "");
-        tlsTrustCertFilePath = useSecondIfFirstIsNull(tlsTrustCertFilePath, "");
-        stateStorageImplClass = useSecondIfFirstIsNull(stateStorageImplClass, "");
-        stateStorageServiceUrl = useSecondIfFirstIsNull(stateStorageServiceUrl, "");
-        secretsProviderClassName = useSecondIfFirstIsNull(secretsProviderClassName, "");
-        secretsProviderConfig = useSecondIfFirstIsNull(secretsProviderConfig, "");
+//        jarFile = useSecondIfFirstIsNull(jarFile, "");
+//        transformFunctionJarFile = useSecondIfFirstIsNull(transformFunctionJarFile, "");
+//        transformFunctionId = useSecondIfFirstIsNull(transformFunctionId, "");
+//        clientAuthenticationPlugin = useSecondIfFirstIsNull(clientAuthenticationPlugin, "");
+//        clientAuthenticationParameters = useSecondIfFirstIsNull(clientAuthenticationParameters, "");
+//        tlsTrustCertFilePath = useSecondIfFirstIsNull(tlsTrustCertFilePath, "");
+//        stateStorageImplClass = useSecondIfFirstIsNull(stateStorageImplClass, "");
+//        stateStorageServiceUrl = useSecondIfFirstIsNull(stateStorageServiceUrl, "");
+//        secretsProviderClassName = useSecondIfFirstIsNull(secretsProviderClassName, "");
+//        secretsProviderConfig = useSecondIfFirstIsNull(secretsProviderConfig, "");
         narExtractionDirectory = useSecondIfFirstIsNull(
                 narExtractionDirectory,
                 NarClassLoader.DEFAULT_NAR_EXTRACTION_DIR);
-        webServiceUrl = useSecondIfFirstIsNull(webServiceUrl, null);
+//        webServiceUrl = useSecondIfFirstIsNull(webServiceUrl, null);
 
         // Integer
         maxPendingAsyncRequests = useSecondIfFirstIsNull(maxPendingAsyncRequests, 1000);
@@ -684,7 +684,6 @@ private void useDefaultValueIfBothFileAndJCommanderNotProvided() {
     }
 
 
-
     // TODO this method can be replaced with requireNonNullElse() after Java 9.
     private <T> T useSecondIfFirstIsNull(T valueToTest, T valueIfNull) {
         if (Objects.isNull(valueToTest)) {
@@ -715,7 +714,7 @@ protected void setConfigs(String[] args) throws IOException{
 
         // completeConfigFromFileIfCmdArgNotProvided();
         validateRequiredConfigs();
-        // useDefaultValueIfBothFileAndJCommanderNotProvided();
+        useDefaultValueIfBothFileAndJCommanderNotProvided();
     }
 
     protected static Set<String> requireConfigFieldsNames = new HashSet<>(){{