Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TLS authentication and customized volumes #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomjo
Copy link
Contributor

@tomjo tomjo commented Jan 23, 2024

Master Issue: #108

Motivation

Helm chart changes related to #143 Adds the updated CRD and adds support for volumes to the operator to provide the necessary certificates (e.g. from a secret). I bumped the version to v0.5.0 because that is the milestone tag used on #143.

Modifications

  • Adds the updated CRD to support TLS authentication
  • Adds support for volumes/volumeMounts to the operator to provide the necessary certificates for TLS authentication (e.g. from a secret)

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added helm chart test for default values - no volume/volumeMount is added to the deployment

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@tomjo tomjo requested review from a team as code owners January 23, 2024 12:28
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jan 23, 2024
@tomjo tomjo force-pushed the feature/tlsauthhelm branch 2 times, most recently from ba7416a to 6e37f6e Compare January 24, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant