refactor: remove generated protobuf files from the repo #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
network
juslesan
added a commit
that referenced
this pull request
Dec 3, 2024
Reverting PR #2820 due to backwards incompatibility with production. The typeUrl of the PeerDescriptors in the Any protobuf message has changes from `dht.PeerDescriptor` to `peerDescriptor.PeerDescriptor` in this change. This makes it impossible to parse the stream entry points stored stored in the DHT causing stream joining to not work. The clean up of generated protobuf code will be implemented in #2842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please provide a summary of the changes and a motivation if applicable.
Changes
Provide a bullet list of individual changes. Leave this section out if change
set is small and obvious from summary.
Limitations and future improvements
Provide a bullet list or description of known omissions or limitations of the
solution and/or any ideas for future improvement. Leave section ouf if
not applicable.
Checklist before requesting a review
TODOcomments left behind are meant to be left in.