-
Notifications
You must be signed in to change notification settings - Fork 43
chore: Eslint v9 #2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chore: Eslint v9 #2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtakalai
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Converted the configuration file to flat config and unified to config file style. Otherwise same rules are earlier, except:
eslint-config-streamr-ts
cli-tools
logging statements to useconsole.info
instead ofconsole.log
and removed theno-console
rule from that packageFixed lint errors and removed obsolete
eslint-disable
directives. Also fixed a type inOperator.test.ts
.Added
eslint-import-resolver-typescript
dependency. It is needed byeslint-plugin-import
(see https://github.com/import-js/eslint-plugin-import?tab=readme-ov-file#typescript).Other PRs
Temporarily disabled linting of browser classes in commit 876423f. That is needed until we merge #2848 to
main
. We should revert the commit either in this PR or in that PR (whichever is landed tomain
later).