Skip to content

Conversation

teogeb
Copy link
Contributor

@teogeb teogeb commented Oct 25, 2024

Changes

Converted the configuration file to flat config and unified to config file style. Otherwise same rules are earlier, except:

  • some new rules are now inherited from the updated eslint-config-streamr-ts
    • removed locally defined rules if exactly same as inherited
  • converted cli-tools logging statements to use console.info instead of console.log and removed the no-console rule from that package

Fixed lint errors and removed obsolete eslint-disable directives. Also fixed a type in Operator.test.ts.

Added eslint-import-resolver-typescript dependency. It is needed by eslint-plugin-import (see https://github.com/import-js/eslint-plugin-import?tab=readme-ov-file#typescript).

Other PRs

Temporarily disabled linting of browser classes in commit 876423f. That is needed until we merge #2848 to main. We should revert the commit either in this PR or in that PR (whichever is landed to main later).

@github-actions github-actions bot added network Related to Network Package test-utils Related to Test Utils Package cli-tools Related to CLI Tools Package dht Related to DHT package utils proto-rpc sdk node labels Oct 25, 2024
@teogeb teogeb marked this pull request as ready for review October 29, 2024 22:14
@teogeb teogeb requested review from juslesan and jtakalai October 29, 2024 22:14
@teogeb teogeb merged commit 10e1e41 into main Nov 6, 2024
24 checks passed
@teogeb teogeb deleted the eslint-v9 branch November 6, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli-tools Related to CLI Tools Package dht Related to DHT package network Related to Network Package node proto-rpc sdk test-utils Related to Test Utils Package utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants