feat(node): [NET-1381] Add version to operator heartbeats #2918
+26
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teogeb
force-pushed
the
NET-1381-write-version-to-operator-heartbeats
branch
from
05c4b7e
to
626b5c2
Compare
mondoreale
approved these changes
Dec 4, 2024
| @@ -1,5 +1,6 @@ | |||
| import { createHeartbeatMessage, HeartbeatMessageSchema } from '../../../../src/plugins/operator/heartbeatUtils' | |||
| import { omit } from 'lodash' | |||
There was a problem hiding this comment.
Maybe
import omit from 'lodash/omit'There was a problem hiding this comment.
@mondoreale Is this needed anymore when we start to use rollup? We have multiple import { ... } from 'lodash' style imports currently in the codebase. If we change this, should we change all other occurences, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
versionfield to the heartbeat message (published byannounceNodeToStream).TODO
Test the backward compatibility in practice