refactor(sdk): Replace quick-lru with lru-cache
#2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead-of-CacheMap-in-registries
This reverts commit e5bfdcf.
mondoreale
changed the base branch from
main
to
sdk-use-Mapping-instead-of-CacheMap-in-registries
mondoreale
force-pushed
the
swap-lru-library
branch
from
c43a6cb
to
0242fd4
Compare
The motivation here is that unlike `quick-lru` `lru-cache` comes in 2 formats we're interested in: cjs and esm. Plus, DHT already uses `lru-cache` so it already fits the stack.
Incorrect param!
mondoreale
force-pushed
the
swap-lru-library
branch
from
3cf45e0
to
3917a4b
Compare
mondoreale
commented
Dec 3, 2024
There was a problem hiding this comment.
Let me revert this one. Most likely node v18 vs v20 issue.
There was a problem hiding this comment.
Can't get this to pass locally. "Me" problem, it seems. CI sees no issues.
Locally it fails. Let's push it and see if it's a "me" problem.
Base automatically changed from
sdk-use-Mapping-instead-of-CacheMap-in-registries
to
main
December 4, 2024 12:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Hopefully one of many small PRs.)
Summary
quick-lruis an ES-only package and in order to build with it for CJS we currently move it (raw ESM) over (to/vendor) and transform to CommonJS as part of SDK's build process.lru-cacheis already being used by DHT and it organically comes in 2 flavours: CJS and ESM. No magic required, and no magic = less maintenance.Changes
Mapping.Checklist before requesting a review
Is this a breaking change? If it is, be clear in summary.TODOcomments left behind are meant to be left in.Updated changelog if applicable.Updated documentation if applicable.Remaining todos