refactor(sdk): Support multiple contracts in ChainEventPoller
#2928
Conversation
|
To address your point
We had a discussion on video meeting (me and Teo ofc), maybe better to leave out and have it as caller's responsibility (especially since it was like this before). On that front, regarding the |
| address: uniq(this.listeners.map((l) => l.contractAddress)), | ||
| topics: [uniq(this.listeners.map((l) => l.contractInterfaceFragment.topicHash))], |
There was a problem hiding this comment.
We need to check that this definitely works as we think it does
| } | ||
|
|
||
| const createEventLogItem = ( | ||
| eventName: string, eventArgs: any[], blockNumber: number |
There was a problem hiding this comment.
| eventName: string, eventArgs: any[], blockNumber: number | |
| eventName: string, | |
| eventArgs: any[], | |
| blockNumber: number |
| ): Partial<Log> => { | ||
| const contractInterface = new Interface(createAbi(eventName)) | ||
| return { | ||
| blockNumber: blockNumber, |
There was a problem hiding this comment.
| blockNumber: blockNumber, | |
| blockNumber, |
| logger.debug('Polling', { fromBlock, eventNames }) | ||
| events = await contract.queryFilter([eventNames], fromBlock) as EventLog[] | ||
| const filter = { |
There was a problem hiding this comment.
Maybe worth commenting how the filtering logic here works, e.g.
address == (X OR Y OR Z) AND topic === (A OR B OR C)
Refactored
ChainEventPollerto support multiple contracts simultaneously. Now the class is a singleton and we can define contract methods as a listener parameter. This optimizes log fetching as there needs to be only one poller running even if multiple contract events are listened.Also we don't now need to create a
Contractinstance just for adding event a listener. This allows us to simplify e.g.Operatorclass (in a follow-up PR).