style: Cosmetic fixes #141
Conversation
kare
commented
Sep 3, 2021
•
kare
commented
- Add chainlink_cofig/tempkeys to .gitignore
- Unify chainlink naming
| @@ -2,3 +2,4 @@ data/ | |||
| .idea | |||
| .env | |||
| certs/ | |||
| /chainlink_config/tempkeys | |||
There was a problem hiding this comment.
removing these keys ( - I think, didn't test ist recently - ) might result in the chainlink node creating new ones, so it probably will not work with the preloaded addresses on the sidechain. The chainlink node wont have any funds on its new address and then can't create transactions. Unless these keys are also in the database file, shared to the chainlink container, then it might still work without these key files.
The crosschain chainlink e2e workflow needs to be tested without these files before removing them, I will try to do this today before my holiday...
There was a problem hiding this comment.
@samt1803 This isn't urgent, just like the title says
There was a problem hiding this comment.
These changes currently break the chainlink workflow. https://linear.app/streamr/issue/ETH-155 needs to be done first, then this PR can be revisited.
(The workflow also needs to be run in an integrationtest by the github CI: the ticket is, https://linear.app/streamr/issue/ETH-137)
| @@ -478,7 +478,7 @@ services: | |||
| timeout: 10s | |||
| retries: 60 | |||
| chainlink-external-adapter: | |||
| container_name: streamr-dev-chainlink-adapter | |||
| container_name: streamr-dev-chainlink-external-adapter | |||
There was a problem hiding this comment.
this breaks the chainlink workflow because it is linked directly to the container, instead of 10.200.10.1. I created a ticket to fix this: https://linear.app/streamr/issue/ETH-155
