Add GitHub action to push image to Quay.io #10
Conversation
katheris
commented
Aug 19, 2024
katheris
commented
- Add GitHub action to push image to Quay.io.
- Update instructions to make image build optional.
|
@MikeEdgar could you create the data-generator repository in quay? |
* Add GitHub action to push image to Quay.io. * Update instructions to make image build optional. Signed-off-by: Katherine Stanley <[email protected]>
katheris
force-pushed
the
add-ci-pipeline
branch
from
815d4be to
4e2187d
Compare
@katheris , can we call it |
I don't have a problem with |
Ultimately, probably not. I see that this one is using Avro to generate data and the one we developed for the console is meant to generate variable producer/consumer traffic to put interesting data in the console's metrics graphs. |
|
Build is timing out waiting for someone to agree to install the packages 😬 need to add a |
* Update cert-manager and flink operator versions. * Update data-generator image name to flink-examples-data-generator. * Add missing -y to microdnf update command. Signed-off-by: Katherine Stanley <[email protected]>
katheris
force-pushed
the
add-ci-pipeline
branch
from
4d70020 to
2e84462
Compare
The data generator in this repo is designed specifically to generate data for the examples in this repo, I avoided creating a generic data generator, as there are already other examples of generic data generators for Kafka. I've gone with the name |
|
I'm not going to hold up anything over it but I do think it's odd to have two unrelated data generators in the same organisation. And yes I get that they have different goals today but I would expect they could be unified into a single tool which could service the needs of both. |
