Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch flink deployment to run on openshift #11

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Patch flink deployment to run on openshift #11

merged 1 commit into from
Aug 21, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Aug 20, 2024

This patch allows to run flink example CR on openshift in more restricted env then minikube/kind environemnt. It fixes the podTemplate to mount emptyDirs to allow write logs and data by flink on local disk.

This patch allows to run flink example CR on openshift in more restricted env then minikube/kind environemnt. 
It fixes the podTemplate to mount emptyDirs to allow write logs and data by flink on local disk.
@kornys kornys requested a review from katheris August 20, 2024 17:42
@kornys kornys self-assigned this Aug 20, 2024
@kornys kornys requested a review from tinaselenge August 20, 2024 17:47
Copy link
Collaborator

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katheris
Copy link
Collaborator

I'm having issues provisioning an OpenShift cluster this morning so haven't tested the change on OpenShift but it works fine locally on minikube still so happy to approve as the change LGTM

@kornys kornys merged commit 63ec319 into main Aug 21, 2024
1 check passed
@kornys kornys deleted the ocp-patch branch August 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants