Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename apicurio service in examples #14

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Rename apicurio service in examples #14

merged 2 commits into from
Aug 27, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Aug 26, 2024

I renamed apicurio service due to follow same pattern as if apicurio registry are created by apicurio operator, so if deployment is named XX, then service is named XX-service.

@kornys kornys self-assigned this Aug 26, 2024
Signed-off-by: David Kornel <[email protected]>
Copy link
Collaborator

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks @kornys

@kornys kornys merged commit 99906a0 into main Aug 27, 2024
1 check passed
@kornys kornys deleted the apicurio-service-rename branch August 27, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants