Add check for helm repo to interactive elt setup script #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomncooper
force-pushed
the
etl-setup-helm
branch
2 times, most recently
from
a755d31 to
e1a4add
Compare
kornys
approved these changes
Oct 30, 2024
Signed-off-by: Thomas Cooper <[email protected]>
tomncooper
force-pushed
the
etl-setup-helm
branch
from
e1a4add to
38b0b23
Compare
kornys
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check, for the flink operator helm repo, to the Interactive ETL demo setup script.
If you already have the repo setup with an older version the
helm repo addcommand will fail so this checks if you have the required repo version installed and force updates to the required version if not.It also increases the default timeout as the Kafka broker setup usually takes more than 2mins on my (reasonably powerful) laptop.