Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instruction to run jobs in other namespace #30

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

showuon
Copy link
Contributor

@showuon showuon commented Oct 31, 2024

  1. Provide example flink service account yaml file
  2. Provide instruction to run flink jobs on other namespace

@showuon showuon requested a review from kornys October 31, 2024 12:25
@kornys
Copy link
Member

kornys commented Oct 31, 2024

It wont work, you removed finalizers rights which are needed on ocp.

@kornys
Copy link
Member

kornys commented Oct 31, 2024

Also i miss rights to read secrets to use connection info for kafka connecting

Copy link
Member

@kornys kornys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my comments.

@showuon
Copy link
Contributor Author

showuon commented Nov 1, 2024

Thanks for the comment, @kornys ! It makes sense we should add finalizer and secret permissions. PR updated. Thanks.

@kornys
Copy link
Member

kornys commented Nov 1, 2024

Thanks for the comment, @kornys ! It makes sense we should add finalizer and secret permissions. PR updated. Thanks.

@showuon just out of curiosity why don't you use same example as I added to jira issue which I sent you?

because I miss pods/finalizers and also secrets should be just get,list not all rights.

@showuon
Copy link
Contributor Author

showuon commented Nov 1, 2024

Thanks for the comment, @kornys ! It makes sense we should add finalizer and secret permissions. PR updated. Thanks.

@showuon just out of curiosity why don't you use same example as I added to jira issue which I sent you?

because I miss pods/finalizers and also secrets should be just get,list not all rights.

Thanks for the comment. PR updated!

@showuon showuon merged commit 6a8d26b into streamshub:main Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants