Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a proper test for flink-sql-examples #26

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Create a proper test for flink-sql-examples #26

merged 7 commits into from
Aug 27, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Aug 26, 2024

No description provided.

@kornys kornys self-assigned this Aug 26, 2024
@kornys kornys marked this pull request as ready for review August 27, 2024 10:41
@kornys kornys requested a review from Frawless August 27, 2024 10:41
Signed-off-by: David Kornel <[email protected]>
@kornys
Copy link
Member Author

kornys commented Aug 27, 2024

/packit test --labels sql-example

Signed-off-by: David Kornel <[email protected]>
@kornys
Copy link
Member Author

kornys commented Aug 27, 2024

/packit test --labels sql-example

Copy link

@tinaselenge tinaselenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess, in the future when we add examples with simpler SQL queries, we can check for more specific messages in the output topic.

@kornys
Copy link
Member Author

kornys commented Aug 27, 2024

LGTM. I guess, in the future when we add examples with simpler SQL queries, we can check for more specific messages in the output topic.

yeah sure, this just starting point with example, in future we will use proper clients, flink deployments created by builders etc... :)

@kornys kornys merged commit a268fbb into main Aug 27, 2024
4 checks passed
@kornys kornys deleted the sql-examples branch August 27, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants