delete AddCrossingType from db (fixes #5522)

app/src/main/java/de/westnordost/streetcomplete/data/DatabaseInitializer.kt

@@ -29,7 +29,7 @@ import de.westnordost.streetcomplete.quests.oneway_suspects.data.WayTrafficFlowT
 
 /** Creates the database and upgrades it */
 object DatabaseInitializer {
-    const val DB_VERSION = 15
+    const val DB_VERSION = 16
 
     fun onCreate(db: Database) {
         // OSM notes
@@ -242,9 +242,22 @@ object DatabaseInitializer {
         if (oldVersion <= 14 && newVersion > 14) {
             db.renameOverlay("ShopsOverlay", "PlacesOverlay")
         }
+        if (oldVersion <= 15 && newVersion > 15) {
+            db.deleteQuest("AddCrossingType")
+        }
     }
 }
 
+private fun Database.deleteQuest(name: String) {
+    deleteValue(ElementEditsTable.NAME, ElementEditsTable.Columns.QUEST_TYPE, name)
+    deleteValue(OsmQuestTable.NAME, OsmQuestTable.Columns.QUEST_TYPE, name)
+    deleteValue(OsmQuestsHiddenTable.NAME, OsmQuestsHiddenTable.Columns.QUEST_TYPE, name)
+    deleteValue(VisibleQuestTypeTable.NAME, VisibleQuestTypeTable.Columns.QUEST_TYPE, name)
+    deleteValue(OpenChangesetsTable.NAME, OpenChangesetsTable.Columns.QUEST_TYPE, name)
+    deleteValue(QuestTypeOrderTable.NAME, QuestTypeOrderTable.Columns.BEFORE, name)
+    deleteValue(QuestTypeOrderTable.NAME, QuestTypeOrderTable.Columns.AFTER, name)
+}
+
 private fun Database.renameQuest(old: String, new: String) {
     renameValue(ElementEditsTable.NAME, ElementEditsTable.Columns.QUEST_TYPE, old, new)
     renameValue(OsmQuestTable.NAME, OsmQuestTable.Columns.QUEST_TYPE, old, new)
@@ -263,3 +276,7 @@ private fun Database.renameOverlay(old: String, new: String) {
 private fun Database.renameValue(table: String, column: String, oldValue: String, newValue: String) {
     update(table, listOf(column to newValue), "$column = ?", arrayOf(oldValue))
 }
+
+private fun Database.deleteValue(table: String, column: String, value: String) {
+    delete(table, "$column = ?", arrayOf(value))
+}