Skip to content

Commit

Permalink
Max Height: Ask what is indicated
Browse files Browse the repository at this point in the history
While it is fine to tag maxheight also when it is not signed, there is already a follow-up quest that asks for the physical height if it is not signed. This makes sense for two reasons:
1. It remains quick and easy to answer the quest by clarifying that it is not necessary to measure it if the height is not indicated anywhere
2. It removes the possibility that someone does something possibly stupid: Measure the height of overhead wire

See https://community.openstreetmap.org/t/streetcomplete-fragt-bei-eisenbahn-weg-kreuzung-nach-durchfahrtshohe/103606
  • Loading branch information
westnordost committed Sep 13, 2023
1 parent 3693f9c commit e300eaa
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ class AddMaxHeight : OsmElementQuestType<MaxHeightAnswer> {
&& tags["railway"] != "level_crossing"
// only the "below the bridge" situation may need some context
return when {
isBelowBridge -> R.string.quest_maxheight_below_bridge_title
else -> R.string.quest_maxheight_title
isBelowBridge -> R.string.quest_maxheight_sign_below_bridge_title
else -> R.string.quest_maxheight_sign_title
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ class AddMaxPhysicalHeight(
and access !~ private|no
and vehicle !~ private|no
""".toElementFilterExpression() }
// leaving out railway = level_crossing is deliberate, we do not want people to measure overhead
// cables by hand - bzzzt! - but also (if measured with laser) the result would be wrong, as
// the (signed) max height is always something like 1.5 meter distance to the cable itself

private val wayFilter by lazy { """
ways with
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1083,6 +1083,8 @@ If any lanes are reserved for buses, please leave a note instead."</string>

<string name="quest_maxheight_title">"What’s the height limit here?"</string>
<string name="quest_maxheight_below_bridge_title">What’s the height limit below the bridge?</string>
<string name="quest_maxheight_sign_title">"What height limit is indicated here?"</string>
<string name="quest_maxheight_sign_below_bridge_title">What height limit is indicated below the bridge?</string>
<string name="quest_maxheight_answer_noSign">There is no sign…</string>
<string name="quest_maxheight_split_way_hint">If it doesn’t apply for the whole way, consider answering “%s”.</string>
<string name="quest_maxheight_answer_noSign_question">Is there easily enough space for even the tallest trucks (at least about 4.5 meters / 15 feet) to pass through?</string>
Expand Down

0 comments on commit e300eaa

Please sign in to comment.