Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add computing/software-related terms #4163

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Mar 12, 2025

Add/Fix Dictionary

Dictionary: software-terms.txt

Description

Added some computing/software-related terms.

References

Checklist

  • By submitting this pull-request, you agree to follow our Code of Conduct
  • Verify that the title starts with the correct prefix:
    • fix: - for minor changes like adding words or fixing spelling issues.
    • feat: - for a significant change like adding a whole new set of words to a dictionary.
    • feat!: - for breaking changes, like file format or licensing changes.
    • chore: - for changes that do not impact the content of dictionaries.

@Jason3S
Copy link
Collaborator

Jason3S commented Mar 12, 2025

@kenji-miyake,

Thank you.

Other than clothoid, these are primarily computing / software related terms. I think it is better to add them there. Not everyone has English enabled as a language.

freespace and raytracing are two words. It is ok to add them to software terms as freeSpace and rayTracing.

@kenji-miyake
Copy link
Contributor Author

@Jason3S Thanks for the comment. 🙏 I'll fix them!

@kenji-miyake kenji-miyake marked this pull request as draft March 13, 2025 00:00
@kenji-miyake kenji-miyake changed the title fix: add shared additional words fix: add computing/software-related terms Mar 13, 2025
@kenji-miyake kenji-miyake marked this pull request as ready for review March 13, 2025 02:18
@kenji-miyake
Copy link
Contributor Author

kenji-miyake commented Mar 13, 2025

@Jason3S Fixed it. Could you please retake a look? 🙇 (Moved clothoid as well since it is rarely used outside specific industries.)

@Jason3S
Copy link
Collaborator

Jason3S commented Mar 13, 2025

Looks good. Thank you.

@Jason3S Jason3S merged commit 1fd66f7 into streetsidesoftware:main Mar 13, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants