-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to using the Awesome theme font in spotify-widget #365
base: master
Are you sure you want to change the base?
Default to using the Awesome theme font in spotify-widget #365
Conversation
Switch to the configured beautiful default font instead of arbitrarily choosing Play 9
@streetturtle It seems as though beautiful is already a dependency for several other widgets in the package, though? Why are some allowed to use it and not others? Shouldn't a consistent package-wide default be agreed upon before deciding to not use the theme font? |
AFAIR, the "this library shouldn't use beautiful" comes from #274. The main idea is that some well-known libraries like https://github.com/lcpz/lain and https://github.com/lcpz/awesome-copycats enforces a pattern where the user defines the screen decoration (aka the desktop bar and widgets) in the The fs-widget was the first (and only ?) to get the "new pattern" to not depends on beautiful. I'm not very active on this repository, so I don't know how it went after that. The idea of the "new pattern" I have proposed with #277 is that the themable-values are taken with the priority waterfall
So beautiful should still be a default for the user in a normal usage (aka not the awesome-copicats pattern). |
@@ -33,7 +34,7 @@ local function worker(user_args) | |||
|
|||
local play_icon = args.play_icon or '/usr/share/icons/Arc/actions/24/player_play.png' | |||
local pause_icon = args.pause_icon or '/usr/share/icons/Arc/actions/24/player_pause.png' | |||
local font = args.font or 'Play 9' | |||
local font = args.font or beautiful.font |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following my comment, here is what I think should be the reasonable way to do :
local font = args.font or beautiful.font | |
local font = args.font or beautiful.font or "Play 9" |
This change switches to using the theme font (
beautiful.font
) instead of'Play 9'
. This change brings the widget more in line with the other awesome widgets, particularly since Play is not used as the default in any other widget.