feat: show hourly forecast #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This took me quite some trial and error to figure out. Signed-off-by: André Jaenisch <[email protected]>
|
I want to add an example_response.json to the repo and also respect day/night information as suggested in my last PR before I open this for inclusion. That being said, by opening a PR now I can invite others to check it out and run locally. Feedback welcome. |
trap000d
reviewed
Oct 11, 2024
NeoVim tried to be helpful. Signed-off-by: André Jaenisch <[email protected]>
|
Hi @Ryuno-Ki, Would you consider to [optionally] add popup on mouse hover? weather_widget:connect_signal("mouse::enter", function()
weather_widget:set_bg(beautiful.bg_focus)
weather_popup:move_next_to(mouse.current_widget_geometry)
end)
weather_widget:connect_signal("mouse::leave", function()
if weather_popup.visible then
weather_widget:set_bg('#00000000')
weather_popup.visible = not weather_popup.visible
end
end) |
This was a nice contribution! Co-authored-by: trap000d Signed-off-by: André Jaenisch <[email protected]>
|
Done. |
This should ease the job of updating this widget. Signed-off-by: André Jaenisch <[email protected]>
This was highly requested. I hope I catched all cases. Signed-off-by: André Jaenisch <[email protected]>
|
I think I have everythink now. I can see unrelated failures in luacheck to this extension. @streetturtle Mind taking a review on this? |
|
All works great, thanks a lot. |
I removed the executable flag from all of them. Signed-off-by: André Jaenisch <[email protected]>
|
Good catch! |
I only need to add a prefix when it is not day. Signed-off-by: André Jaenisch <[email protected]>
streetturtle
approved these changes
Oct 27, 2024
|
This is great! Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took me quite some trial and error to figure out.