-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP fix: make hue non nullable #2346
base: master
Are you sure you want to change the base?
Conversation
Technically is a breaking change as Looks good to me though. I doubt that's going to affect anyone. |
That's because It's only used here:
Which is where the thumbnail asset then uses as the color:
The thumbnail only persists as a single color (for a given asset) because As for whether As an FYI, the background color of the header is set here (which is currently not changeable): stride/sources/editor/Stride.Core.Assets.Editor/View/DefaultPropertyTemplateProviders.xaml Line 260 in b40ad46
|
so is that property just useless in the end? seems like a leftover if oyu set hue color the color stays the same for the thumbnail sooo its anyway pointless as the intention is different? |
Very low value since none of the existing assets use it. |
currently setting hue value doesnt compile, and nobody complained |
PR Details
makes property hue non nullable as its a non allowed type for attribute properties.
Types of changes
Checklist
There is no usage in stride of that field thats why it was unnoticed when it was made nullable.
I dont know how to test it out. So i need help someone knowing how to test that out in a project.