Drop support for UWP #2450
Drop support for UWP #2450
Conversation
|
This test is missing " I have built and run the editor to try this change out." 🤣 |
|
@VaclavElias Welp...Testing always takes more time, but if you want to help speed it up, feel free to test it by yourself 😜 |
Jklawreszuk
force-pushed
the
uwp-removal
branch
from
625d4af to
5dc95fa
Compare
| if (Platform.Type != PlatformType.Windows && Platform.Type != PlatformType.UWP) | ||
| throw new NotSupportedException(); |
There was a problem hiding this comment.
This change is wrong, it should still throw when the platform is not windows
| #if STRIDE_GRAPHICS_API_DIRECT3D11 && STRIDE_PLATFORM_UWP | ||
| if (Windows.Graphics.Holographic.HolographicSpace.IsAvailable && GraphicsDevice.Presenter is WindowsMixedRealityGraphicsPresenter) | ||
| { | ||
| Device = new WindowsMixedRealityHmd(); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Might want to throw a not supported here instead of silently failing ? Granted that's what it would have done before outside of UWP
|
Should we reconsider this PR in light of .NET 9 adding legacy support for UWP? At the very least it helps us migrate Stride users away from 4.0 and .NET Framework if they want UWP support. https://devblogs.microsoft.com/ifdef-windows/preview-uwp-support-for-dotnet-9-native-aot/ |
|
@MeharDT I was not aware of this one, you're right, we'll revisit this issue whenever UWP support becomes problematic then |
|
I marked PR as draft for now. We'll see what happens next with UWP support |
PR Details
This PR drops support for UWP and it's codebase.
The main reason is that UWP support has been abandoned since .NET 5 and Microsoft recommends to migrate to MS GDK for Xbox consoles.
That said, the last version that targeted .NET 5 version was a very long time ago (4.1.0.1459-beta) and this PR is also intended to avoid unnecessary frustration for new developers over a feature that is long gone.
Types of changes
Checklist