Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Port NuGetResolver.UI to AvaloniaUI #2512

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

This PR provides a AvaloniaUI port for the NuGetResolver - tool that is run before GameStudio is launched.
The TextBox displaying logs has also been improved - User cannot now edit or delete text and It is readonly

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

Copy link
Member

@Kryptos-FR Kryptos-FR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few minor comments.

WindowStartupLocation="CenterScreen"
WindowStyle="None"
AllowsTransparency="True"
SystemDecorations="None"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: tab -> space

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@Jklawreszuk
Copy link
Collaborator Author

I added the InvokeShutdown method and the window now behaves similarly to WPF NugetResolver - I noticed that the window was closing with some delay
It should be good to go :)

@Kryptos-FR Kryptos-FR merged commit 581cef9 into stride3d:master Jan 25, 2025
2 checks passed
@Jklawreszuk Jklawreszuk deleted the nuget-avalonia branch January 25, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants