fix: Removed Focused loss triggering button Release #2549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
On deselecting Edit Text, via
myEditTextElement.IsSelectionActive = false;
, focus was lost which triggered two behaviors which both triggered button releases. One mouse and keyboard and the other just the mouse release. This PR affects the following inputs: STRIDE_UI_WINFORMS and STRIDE_UI_WPF.I have checked the box that this maybe a breaking change due to the following comment in the removed code.
// Release keys/buttons when control focus is lost (this prevents some keys getting stuck when a focus loss happens when moving the camera)
I tried to test moving the camera around while typing in an EditText, but was not able to reproduce a key or mouse button press being stuck.
My reasoning for a possibly breaking change is that due to
UIControlOnLostFocus
andUIControlOnLostFocus
.If more knowledge on the original goals of the functions
UIControlOnLostFocus
andUIControlOnLostFocus
are known, I will revised this PR to address it.Related Issue
#2084
Types of changes
Checklist
Test Script
Here is the script I used to test if the "Mouse Button Released" was happening on Mouse Press or Release.