Skip to content

Commit

Permalink
Revert "use Node.js 22 instead of Node.js 20 in Dockerfile"
Browse files Browse the repository at this point in the history
This reverts commit f0e0dd4.

Currently, there is no prebuilt for the canvas package for
Node.js 22, so we would have to build it from source and install
all the required dependencies. That would increase the size of
the final Docker image to almost twice the current size, and I
don't think that is acceptable. So let's wait for a newer release
of canvas which brings the corresponding prebuilt package.
  • Loading branch information
striezel committed Nov 10, 2024
1 parent f0e0dd4 commit ed32f50
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ RUN wget https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key && \
cat nodesource-repo.gpg.key | gpg --dearmor -o /usr/share/keyrings/nodesource.gpg && \
chmod 644 /usr/share/keyrings/nodesource.gpg && \
unlink nodesource-repo.gpg.key && \
echo "# Node.js 22.x for Debian 12" > /etc/apt/sources.list.d/nodejs.list \
&& echo "deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_22.x nodistro main" >> /etc/apt/sources.list.d/nodejs.list && \
echo "# Node.js 20.x for Debian 12" > /etc/apt/sources.list.d/nodejs.list \
&& echo "deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" >> /etc/apt/sources.list.d/nodejs.list && \
apt-get update && apt-get install --no-install-recommends -y nodejs
# Create directory for application.
RUN mkdir -p /opt/export-server
Expand Down
6 changes: 0 additions & 6 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@ Since [ECharts](https://echarts.apache.org/) is the main dependency of this
application, major version changes in ECharts will also trigger a major version
change in this application.

## Version ?.?.? (2024-11-??)

* __[maintenance]__
Update Dockerfile to use Node.js 22 instead of Node.js 20. Node.js 22 is the
current active LTS release of Node.js.

## Version 6.0.5 (2024-10-29)

* __[maintenance]__
Expand Down

0 comments on commit ed32f50

Please sign in to comment.