Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant write permissions only when a maintainer triggered a CI #1612

Merged

Conversation

hibariya
Copy link
Collaborator

@hibariya hibariya commented Mar 11, 2023

See #1613 for the details.

Copy link

@ANGELAFN75 ANGELAFN75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@hibariya hibariya force-pushed the maintainers-can-run-tests branch 3 times, most recently from 3453ae8 to 1e469ce Compare March 11, 2023 10:20
Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


env:
STRIPE_PUBLISHABLE_KEY: ${{ secrets.TEST_STRIPE_PUBLISHABLE_KEY }}
STRIPE_SECRET_KEY: ${{ secrets.TEST_STRIPE_SECRET_KEY }}
COMPOSE_FILE: docker-compose.yml:docker-compose.playwright.yml
MAINTAINERS: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we automate getting this list?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I create the issue to take over it.
#1773

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e

@hibariya hibariya marked this pull request as ready for review May 25, 2023 09:21
@paulasjes-stripe paulasjes-stripe merged commit 7ee1421 into stripe-samples:main May 25, 2023
hibariya added a commit to hibariya/subscription-use-cases that referenced this pull request Nov 5, 2023
hibariya added a commit to hibariya/checkout-one-time-payments that referenced this pull request Feb 12, 2024
Applied the changes the same as the following PRs to the CI workflow here:

- stripe-samples/accept-a-payment#1385
- stripe-samples/accept-a-payment#1612

Also, updated Flask and Capybara configurations to fix failing tests.
hibariya added a commit to hibariya/subscription-use-cases that referenced this pull request Feb 12, 2024
hibariya added a commit to hibariya/subscription-use-cases that referenced this pull request Feb 12, 2024
kirillihub pushed a commit to kirillihub/checkout-one-time-payments that referenced this pull request Mar 8, 2024
Applied the changes the same as the following PRs to the CI workflow here:

- stripe-samples/accept-a-payment#1385
- stripe-samples/accept-a-payment#1612

Also, updated Flask and Capybara configurations to fix failing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants