-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant write permissions only when a maintainer triggered a CI #1612
Grant write permissions only when a maintainer triggered a CI #1612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
3453ae8
to
1e469ce
Compare
1e469ce
to
165b7c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
env: | ||
STRIPE_PUBLISHABLE_KEY: ${{ secrets.TEST_STRIPE_PUBLISHABLE_KEY }} | ||
STRIPE_SECRET_KEY: ${{ secrets.TEST_STRIPE_SECRET_KEY }} | ||
COMPOSE_FILE: docker-compose.yml:docker-compose.playwright.yml | ||
MAINTAINERS: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we automate getting this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I create the issue to take over it.
#1773
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e
Applied the same settings as: - stripe-samples/accept-a-payment#1385 - stripe-samples/accept-a-payment#1612
Applied the changes the same as the following PRs to the CI workflow here: - stripe-samples/accept-a-payment#1385 - stripe-samples/accept-a-payment#1612 Also, updated Flask and Capybara configurations to fix failing tests.
Applied the same settings as: - stripe-samples/accept-a-payment#1385 - stripe-samples/accept-a-payment#1612
Applied the same settings as: - stripe-samples/accept-a-payment#1385 - stripe-samples/accept-a-payment#1612
Applied the changes the same as the following PRs to the CI workflow here: - stripe-samples/accept-a-payment#1385 - stripe-samples/accept-a-payment#1612 Also, updated Flask and Capybara configurations to fix failing tests.
See #1613 for the details.