-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
43a6d6f
commit 97fffc8
Showing
8 changed files
with
261 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
internal/migration_acceptance_tests/database_schema_source_cases_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| package migration_acceptance_tests | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "github.com/stripe/pg-schema-diff/pkg/diff" | ||
| "github.com/stripe/pg-schema-diff/pkg/sqldb" | ||
| "github.com/stripe/pg-schema-diff/pkg/tempdb" | ||
| ) | ||
|
|
||
| func databaseSchemaSourcePlanFactory(ctx context.Context, connPool sqldb.Queryable, tempDbFactory tempdb.Factory, newSchemaDDL []string, opts ...diff.PlanOpt) (_ diff.Plan, retErr error) { | ||
| newSchemaDb, err := tempDbFactory.Create(ctx) | ||
| if err != nil { | ||
| return diff.Plan{}, fmt.Errorf("creating temp database: %w", err) | ||
| } | ||
|
|
||
| defer func() { | ||
| tempDbErr := newSchemaDb.Close(ctx) | ||
| if retErr == nil { | ||
| retErr = tempDbErr | ||
| } | ||
| }() | ||
|
|
||
| for _, stmt := range newSchemaDDL { | ||
| if _, err := newSchemaDb.ConnPool.ExecContext(ctx, stmt); err != nil { | ||
| return diff.Plan{}, fmt.Errorf("running DDL: %w", err) | ||
| } | ||
| } | ||
|
|
||
| // Clone the opts so we don't modify the original. | ||
| opts = append([]diff.PlanOpt(nil), opts...) | ||
| opts = append(opts, diff.WithTempDbFactory(tempDbFactory)) | ||
| for _, o := range newSchemaDb.ExcludeMetadatOptions { | ||
| opts = append(opts, diff.WithGetSchemaOpts(o)) | ||
| } | ||
|
|
||
| return diff.Generate(ctx, connPool, diff.DBSchemaSource(newSchemaDb.ConnPool), opts...) | ||
| } | ||
|
|
||
| var databaseSchemaSourceTestCases = []acceptanceTestCase{ | ||
| { | ||
| name: "Drop partitioned table, Add partitioned table with local keys", | ||
| oldSchemaDDL: []string{ | ||
| ` | ||
| CREATE TABLE fizz(); | ||
| CREATE TABLE foobar( | ||
| id INT, | ||
| bar SERIAL NOT NULL, | ||
| foo VARCHAR(255) DEFAULT 'some default' NOT NULL CHECK (LENGTH(foo) > 0), | ||
| fizz TIMESTAMPTZ DEFAULT CURRENT_TIMESTAMP, | ||
| PRIMARY KEY (foo, id), | ||
| UNIQUE (foo, bar) | ||
| ) PARTITION BY LIST(foo); | ||
| CREATE TABLE foobar_1 PARTITION of foobar( | ||
| fizz NOT NULL | ||
| ) FOR VALUES IN ('foobar_1_val_1', 'foobar_1_val_2'); | ||
| -- partitioned indexes | ||
| CREATE INDEX foobar_normal_idx ON foobar(foo, bar); | ||
| CREATE UNIQUE INDEX foobar_unique_idx ON foobar(foo, fizz); | ||
| -- local indexes | ||
| CREATE INDEX foobar_1_local_idx ON foobar_1(foo, bar); | ||
| CREATE table bar( | ||
| id VARCHAR(255) PRIMARY KEY, | ||
| foo VARCHAR(255), | ||
| bar DOUBLE PRECISION NOT NULL DEFAULT 8.8, | ||
| fizz TIMESTAMPTZ DEFAULT CURRENT_TIMESTAMP, | ||
| buzz REAL NOT NULL CHECK (buzz IS NOT NULL), | ||
| FOREIGN KEY (foo, fizz) REFERENCES foobar (foo, fizz) | ||
| ); | ||
| CREATE INDEX bar_normal_idx ON bar(bar); | ||
| CREATE INDEX bar_another_normal_id ON bar(bar, fizz); | ||
| CREATE UNIQUE INDEX bar_unique_idx on bar(fizz, buzz); | ||
| `, | ||
| }, | ||
| newSchemaDDL: []string{ | ||
| ` | ||
| CREATE TABLE fizz(); | ||
| CREATE SCHEMA schema_1; | ||
| CREATE TABLE schema_1.foobar( | ||
| bar TIMESTAMPTZ NOT NULL, | ||
| fizz TIMESTAMPTZ DEFAULT CURRENT_TIMESTAMP, | ||
| id INT, | ||
| foo VARCHAR(255) DEFAULT 'some default' NOT NULL CHECK (LENGTH(foo) > 0), | ||
| UNIQUE (foo, bar) | ||
| ) PARTITION BY LIST(foo); | ||
| CREATE TABLE schema_1.foobar_1 PARTITION of schema_1.foobar( | ||
| fizz NOT NULL, | ||
| PRIMARY KEY (foo, bar) | ||
| ) FOR VALUES IN ('foobar_1_val_1', 'foobar_1_val_2'); | ||
| -- local indexes | ||
| CREATE INDEX foobar_1_local_idx ON schema_1.foobar_1(foo, bar); | ||
| -- partitioned indexes | ||
| CREATE INDEX foobar_normal_idx ON schema_1.foobar(foo, bar); | ||
| CREATE UNIQUE INDEX foobar_unique_idx ON schema_1.foobar(foo, fizz); | ||
| CREATE table bar( | ||
| id VARCHAR(255) PRIMARY KEY, | ||
| foo VARCHAR(255), | ||
| bar DOUBLE PRECISION NOT NULL DEFAULT 8.8, | ||
| fizz TIMESTAMPTZ DEFAULT CURRENT_TIMESTAMP, | ||
| buzz REAL NOT NULL CHECK (buzz IS NOT NULL), | ||
| FOREIGN KEY (foo, fizz) REFERENCES schema_1.foobar (foo, fizz) | ||
| ); | ||
| CREATE INDEX bar_normal_idx ON bar(bar); | ||
| CREATE INDEX bar_another_normal_id ON bar(bar, fizz); | ||
| CREATE UNIQUE INDEX bar_unique_idx on bar(fizz, buzz); | ||
| `, | ||
| }, | ||
| expectedHazardTypes: []diff.MigrationHazardType{ | ||
| diff.MigrationHazardTypeAcquiresShareRowExclusiveLock, | ||
| diff.MigrationHazardTypeDeletesData, | ||
| }, | ||
|
|
||
| planFactory: databaseSchemaSourcePlanFactory, | ||
| }, | ||
| } | ||
|
|
||
| func (suite *acceptanceTestSuite) TestDatabaseSchemaSourceTestCases() { | ||
| suite.runTestCases(databaseSchemaSourceTestCases) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.