Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sendable struct instead of class #1818

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

The problem here is that a call within the stripe-ios library to initialize a PKPaymentAuthorizationResult is passing the error that we pass in from RN, which conforms to this class, which is not "sendable". but PKPaymentAuthorizationResult expects that it is sendable. classes can be made sendable, but we should just use a struct here

Motivation

fixes #1748

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe requested review from a team as code owners January 24, 2025 18:44
@wooj-stripe wooj-stripe self-requested a review January 24, 2025 22:04
wooj-stripe
wooj-stripe previously approved these changes Jan 24, 2025
ios/StripeSdk.swift Show resolved Hide resolved
@wooj-stripe wooj-stripe force-pushed the charliecruzan-fix-1748 branch from 006b7f9 to 8841a55 Compare January 27, 2025 23:34
@wooj-stripe wooj-stripe merged commit 66774fe into master Jan 28, 2025
4 of 6 checks passed
@wooj-stripe wooj-stripe deleted the charliecruzan-fix-1748 branch January 28, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crash when /create-intent request fails during apple pay
2 participants