Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all external APIs failure gracefully #133

Closed
wants to merge 0 commits into from
Closed

Handle all external APIs failure gracefully #133

wants to merge 0 commits into from

Conversation

Jemiiah
Copy link
Contributor

@Jemiiah Jemiiah commented Sep 14, 2024

PR Fixes:

  • 1 use try catch for all api
  • 2 return fallback data on failure
  • 3 log/toast failure

Resolves #111

Checklist before requesting a review

  • [✅] I have performed a self-review of my code
  • [✅] I assure there is no similar/duplicate pull request regarding same issue
  • [✅] My PR passes all checks (build, lint, formatting, etc)

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Sep 16, 2024

@akiraonstarknet you haven't reviewed this work

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Sep 17, 2024

@akiraonstarknet please review🙃

@EjembiEmmanuel
Copy link
Contributor

@Jemiiah please resolve conflicts. Otherwise lgtm!

@Jemiiah Jemiiah closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Handle all external APIs failure gracefully
2 participants
@Jemiiah @EjembiEmmanuel