Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sort feature #172

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Conversation

martinvibes
Copy link
Contributor

@martinvibes martinvibes commented Oct 10, 2024

PR Fixes:

  • 1 adds sort feature

Resolves #167

Strkfarm-client vercel

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue
  • My PR passes all checks (build, lint, formatting, etc)

@martinvibes
Copy link
Contributor Author

hello @akiraonstarknet kindly review :)

@akiraonstarknet
Copy link
Contributor

@martinvibes i think there is an issue where sort fails once we sort all columns. Attached video.
sorter-issue.webm

@martinvibes
Copy link
Contributor Author

hello @akiraonstarknet kindly review :)

@akiraonstarknet akiraonstarknet merged commit 506205f into strkfarm:dev Oct 14, 2024
1 check passed
@akiraonstarknet
Copy link
Contributor

@all-contributors please add @martinvibes for code

Copy link
Contributor

@akiraonstarknet

I've put up a pull request to add @martinvibes! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Add sort feature in find yields and strategies tabs
3 participants